crypto: omap-des - Drop if with an always false condition
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Tue, 5 Jul 2022 20:51:42 +0000 (22:51 +0200)
committerHerbert Xu <herbert@gondor.apana.org.au>
Fri, 15 Jul 2022 08:43:21 +0000 (16:43 +0800)
The remove callback is only called after probe completed successfully.
In this case platform_set_drvdata() was called with a non-NULL argument
and so dd is never NULL.

This is a preparation for making platform remove callbacks return void.

While touching this driver remove an assignment without effect.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/omap-des.c

index 538aff8..f783769 100644 (file)
@@ -1091,9 +1091,6 @@ static int omap_des_remove(struct platform_device *pdev)
        struct omap_des_dev *dd = platform_get_drvdata(pdev);
        int i, j;
 
-       if (!dd)
-               return -ENODEV;
-
        spin_lock_bh(&list_lock);
        list_del(&dd->list);
        spin_unlock_bh(&list_lock);
@@ -1106,7 +1103,6 @@ static int omap_des_remove(struct platform_device *pdev)
        tasklet_kill(&dd->done_task);
        omap_des_dma_cleanup(dd);
        pm_runtime_disable(dd->dev);
-       dd = NULL;
 
        return 0;
 }