slimbus: qcom: Remove unnecessary print function dev_err()
authorYang Li <yang.lee@linux.alibaba.com>
Tue, 10 May 2022 09:52:05 +0000 (10:52 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 19 May 2022 16:56:32 +0000 (18:56 +0200)
The print function dev_err() is redundant because
platform_get_irq_byname() already prints an error.

Eliminate the follow coccicheck warning:
./drivers/slimbus/qcom-ctrl.c:514:2-9: line 514 is redundant because
platform_get_irq() already prints an error

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Link: https://lore.kernel.org/r/20220510095205.337-3-srinivas.kandagatla@linaro.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/slimbus/qcom-ctrl.c

index ec58091fc948a26608baf717a44d67c679d180e0..c0c4f895d76e204561d33156db434ca81763d4c2 100644 (file)
@@ -510,10 +510,8 @@ static int qcom_slim_probe(struct platform_device *pdev)
        }
 
        ctrl->irq = platform_get_irq(pdev, 0);
-       if (ctrl->irq < 0) {
-               dev_err(&pdev->dev, "no slimbus IRQ\n");
+       if (ctrl->irq < 0)
                return ctrl->irq;
-       }
 
        sctrl = &ctrl->ctrl;
        sctrl->dev = &pdev->dev;