Remove parenting of QWebSockets in QWebSocketServer
authorKurt Pattyn <pattyn.kurt@gmail.com>
Sun, 2 Feb 2014 17:34:02 +0000 (18:34 +0100)
committerThe Qt Project <gerrit-noreply@qt-project.org>
Sun, 2 Feb 2014 21:42:37 +0000 (22:42 +0100)
Because QWebSocketServer took ownership of QWebSocket objects,
the objects were double deleted, leading to crashes.

Change-Id: I51192daba8e8739bc68a94c7fe2a8a972ac9d38e
Reviewed-by: Kurt Pattyn <pattyn.kurt@gmail.com>
src/websockets/qwebsocketserver_p.cpp

index 47f24d2..617e8fc 100644 (file)
@@ -427,7 +427,6 @@ void QWebSocketServerPrivate::handshakeReceived()
                                                                             request,
                                                                             response);
                     if (pWebSocket) {
-                        pWebSocket->setParent(this);
                         addPendingConnection(pWebSocket);
                         Q_EMIT q->newConnection();
                         success = true;