buildman: Provide a hint on how to debug thread crashes
authorSimon Glass <sjg@chromium.org>
Sat, 22 Jan 2022 12:07:32 +0000 (05:07 -0700)
committerTom Rini <trini@konsulko.com>
Wed, 9 Feb 2022 04:07:59 +0000 (23:07 -0500)
If a thread crashes it is helpful to try the operation again with
threading disabled. Add a hint about that.

Signed-off-by: Simon Glass <sjg@chromium.org>
tools/buildman/builderthread.py
tools/buildman/func_test.py

index 3e450e4..0faa3ac 100644 (file)
@@ -557,6 +557,6 @@ class BuilderThread(threading.Thread):
             try:
                 self.RunJob(job)
             except Exception as e:
-                print('Thread exception:', e)
+                print('Thread exception (use -T0 to run without threads):', e)
                 self.builder.thread_exceptions.append(e)
             self.builder.queue.task_done()
index e09ccb7..c2e0b0b 100644 (file)
@@ -623,4 +623,6 @@ class TestFunctional(unittest.TestCase):
         with test_util.capture_sys_output() as (stdout, stderr):
             self.assertEqual(102, self._RunControl('-o', self._output_dir,
                                                    test_thread_exceptions=True))
-        self.assertIn('Thread exception: test exception', stdout.getvalue())
+        self.assertIn(
+            'Thread exception (use -T0 to run without threads): test exception',
+            stdout.getvalue())