Fix SVACE: UNINIT detect 65/324865/3
authorLe <xuan.tien@samsung.com>
Wed, 28 May 2025 04:38:22 +0000 (11:38 +0700)
committerTien Le <xuan.tien@samsung.com>
Wed, 28 May 2025 08:25:51 +0000 (08:25 +0000)
Change-Id: I37d3227cb909c47635b5f37d89c8cf1a6a5c2aab
Signed-off-by: Le <xuan.tien@samsung.com>
unit-tests/test_vcore_api.cpp
unit-tests/test_vcore_api_cert.cpp

index 2a9d81d1ed5e9ebd74d5d6e8392768b5525438a5..09a2f498cdee8c590d68b9a797afb75f6182b3f1 100644 (file)
@@ -329,7 +329,7 @@ NEGATIVE_TEST_CASE(T_certsvc_pkcs12_has_password_with_invalid_param)
        BOOST_CHECK_EQUAL(result, CERTSVC_SUCCESS);
        BOOST_CHECK_EQUAL(hasPassword, CERTSVC_FALSE);
 
-       CertSvcString certPathEmpty;
+       CertSvcString certPathEmpty = wrapperCertsvcStringNew(instance, "", &result);
        result = certsvc_pkcs12_has_password(instance, certPathEmpty, &hasPassword);
        BOOST_CHECK_EQUAL(result, CERTSVC_IO_ERROR);
        BOOST_CHECK_EQUAL(hasPassword, CERTSVC_FALSE);
index 53d5cf65d036399c9d2917c51582808cf2e10c92..2ff7fba5ec30fba11c2658bcc3a8d13ba895f371 100644 (file)
@@ -648,17 +648,19 @@ NEGATIVE_TEST_CASE(T_certsvc_certificate_chain_sort_wrong_argument)
 
        BOOST_REQUIRE_EQUAL(certsvc_instance_new(&instance), CERTSVC_SUCCESS);
 
+       CertSvcCertificate certInvalid;
+       certInvalid.privateHandler = -1;
+       certInvalid.privateInstance = instance;
+
+       certificate_array[0] = certInvalid;
+       certificate_array[1] = certInvalid;
+
        result = certsvc_certificate_chain_sort(nullptr, size);
        BOOST_CHECK_EQUAL(result, CERTSVC_WRONG_ARGUMENT);
 
        result = certsvc_certificate_chain_sort(certificate_array, 1);
        BOOST_CHECK_EQUAL(result, CERTSVC_WRONG_ARGUMENT);
 
-       CertSvcCertificate certInvalid;
-       certInvalid.privateHandler = -1;
-       certInvalid.privateInstance = instance;
-
-       certificate_array[1] = certInvalid;
        result = certsvc_certificate_chain_sort(certificate_array, size);
        BOOST_CHECK_EQUAL(result, CERTSVC_WRONG_ARGUMENT);
 
@@ -1059,6 +1061,12 @@ NEGATIVE_TEST_CASE(T_certsvc_message_verify)
 
        BOOST_REQUIRE_EQUAL(certsvc_instance_new(&instance), CERTSVC_SUCCESS);
 
+       msg = wrapperCertsvcStringNew(instance, "", &result);
+       sig = wrapperCertsvcStringNew(instance, "", &result);
+
+       cert.privateHandler = -1;
+       cert.privateInstance = instance;
+
        result = certsvc_message_verify(cert, msg, sig, "sha1", NULL);
        BOOST_CHECK_EQUAL(result, CERTSVC_WRONG_ARGUMENT);