projects
/
platform
/
kernel
/
linux-starfive.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
0b0dff5
)
net: dsa: lantiq_gswip: fix use after free in gswip_remove()
author
Alexey Khoroshilov
<khoroshilov@ispras.ru>
Tue, 15 Feb 2022 10:42:48 +0000
(13:42 +0300)
committer
Jakub Kicinski
<kuba@kernel.org>
Thu, 17 Feb 2022 04:39:13 +0000
(20:39 -0800)
of_node_put(priv->ds->slave_mii_bus->dev.of_node) should be
done before mdiobus_free(priv->ds->slave_mii_bus).
Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Fixes:
0d120dfb5d67
("net: dsa: lantiq_gswip: don't use devres for mdiobus")
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Link:
https://lore.kernel.org/r/1644921768-26477-1-git-send-email-khoroshilov@ispras.ru
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/dsa/lantiq_gswip.c
patch
|
blob
|
history
diff --git
a/drivers/net/dsa/lantiq_gswip.c
b/drivers/net/dsa/lantiq_gswip.c
index
320ee7f
..
8a7a809
100644
(file)
--- a/
drivers/net/dsa/lantiq_gswip.c
+++ b/
drivers/net/dsa/lantiq_gswip.c
@@
-2176,8
+2176,8
@@
static int gswip_remove(struct platform_device *pdev)
if (priv->ds->slave_mii_bus) {
mdiobus_unregister(priv->ds->slave_mii_bus);
- mdiobus_free(priv->ds->slave_mii_bus);
of_node_put(priv->ds->slave_mii_bus->dev.of_node);
+ mdiobus_free(priv->ds->slave_mii_bus);
}
for (i = 0; i < priv->num_gphy_fw; i++)