firmware: Use of_property_present() for testing DT property presence
authorRob Herring <robh@kernel.org>
Fri, 10 Mar 2023 14:47:04 +0000 (08:47 -0600)
committerThierry Reding <treding@nvidia.com>
Tue, 4 Apr 2023 19:51:23 +0000 (21:51 +0200)
It is preferred to use typed property access functions (i.e.
of_property_read_<type> functions) rather than low-level
of_get_property/of_find_property functions for reading properties. As
part of this, convert of_get_property/of_find_property calls to the
recently added of_property_present() helper when we just want to test
for presence of a property and nothing more.

Signed-off-by: Rob Herring <robh@kernel.org>
Acked-by: Sudeep Holla <sudeep.holla@arm.com>
Signed-off-by: Thierry Reding <treding@nvidia.com>
drivers/firmware/arm_scmi/optee.c
drivers/firmware/tegra/bpmp.c

index 9297203..e123de6 100644 (file)
@@ -403,7 +403,7 @@ out:
 static int setup_shmem(struct device *dev, struct scmi_chan_info *cinfo,
                       struct scmi_optee_channel *channel)
 {
-       if (of_find_property(cinfo->dev->of_node, "shmem", NULL))
+       if (of_property_present(cinfo->dev->of_node, "shmem"))
                return setup_static_shmem(dev, cinfo, channel);
        else
                return setup_dynamic_shmem(dev, channel);
index 042c204..8b5e5da 100644 (file)
@@ -764,19 +764,19 @@ static int tegra_bpmp_probe(struct platform_device *pdev)
        if (err < 0)
                goto free_mrq;
 
-       if (of_find_property(pdev->dev.of_node, "#clock-cells", NULL)) {
+       if (of_property_present(pdev->dev.of_node, "#clock-cells")) {
                err = tegra_bpmp_init_clocks(bpmp);
                if (err < 0)
                        goto free_mrq;
        }
 
-       if (of_find_property(pdev->dev.of_node, "#reset-cells", NULL)) {
+       if (of_property_present(pdev->dev.of_node, "#reset-cells")) {
                err = tegra_bpmp_init_resets(bpmp);
                if (err < 0)
                        goto free_mrq;
        }
 
-       if (of_find_property(pdev->dev.of_node, "#power-domain-cells", NULL)) {
+       if (of_property_present(pdev->dev.of_node, "#power-domain-cells")) {
                err = tegra_bpmp_init_powergates(bpmp);
                if (err < 0)
                        goto free_mrq;