drm/ttm: fix incrementing the page pointer for huge pages
authorChristian König <christian.koenig@amd.com>
Wed, 10 Apr 2019 09:43:43 +0000 (11:43 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 17 Jan 2020 18:47:02 +0000 (19:47 +0100)
commit 453393369dc9806d2455151e329c599684762428 upstream.

When we increment the counter we need to increment the pointer as well.

Signed-off-by: Christian König <christian.koenig@amd.com>
Fixes: e16858a7e6e7 drm/ttm: fix start page for huge page check in ttm_put_pages()
Reviewed-by: Michel Dänzer <michel.daenzer@amd.com>
Acked-by: Huang Rui <ray.huang@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Cc: Zubin Mithra <zsm@chromium.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/gpu/drm/ttm/ttm_page_alloc.c

index c74147f..627f8dc 100644 (file)
@@ -733,7 +733,7 @@ static void ttm_put_pages(struct page **pages, unsigned npages, int flags,
                        if (!(flags & TTM_PAGE_FLAG_DMA32) &&
                            (npages - i) >= HPAGE_PMD_NR) {
                                for (j = 1; j < HPAGE_PMD_NR; ++j)
-                                       if (p++ != pages[i + j])
+                                       if (++p != pages[i + j])
                                            break;
 
                                if (j == HPAGE_PMD_NR)
@@ -768,7 +768,7 @@ static void ttm_put_pages(struct page **pages, unsigned npages, int flags,
                                break;
 
                        for (j = 1; j < HPAGE_PMD_NR; ++j)
-                               if (p++ != pages[i + j])
+                               if (++p != pages[i + j])
                                    break;
 
                        if (j != HPAGE_PMD_NR)