Move class declaration of Comment from codegen-inl.h to codegen.h

-inl.h files should only contains small inline functions and
no class declarations. Implementation moved to codegen.cc since
it's not a performance critical class (only used in DEBUG mode).

Review URL: http://codereview.chromium.org/585004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3812 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

diff --git a/src/codegen-inl.h b/src/codegen-inl.h
index ea9bf0a4990514e302f05247a1932f40db9bc1c3..da8cbf7034e82dd5555b906f8d285eed6580f22b 100644 (file)
--- a/src/codegen-inl.h
+++ b/src/codegen-inl.h
@@ -49,47 +49,9 @@
 namespace v8 {
 namespace internal {
 
-#define __ ACCESS_MASM(masm_)
-
 Handle<Script> CodeGenerator::script() { return info_->script(); }
 bool CodeGenerator::is_eval() { return info_->is_eval(); }
 
-
-// -----------------------------------------------------------------------------
-// Support for "structured" code comments.
-//
-// By selecting matching brackets in disassembler output,
-// code segments can be identified more easily.
-
-#ifdef DEBUG
-
-class Comment BASE_EMBEDDED {
- public:
-  Comment(MacroAssembler* masm, const char* msg) : masm_(masm), msg_(msg) {
-    __ RecordComment(msg);
-  }
-
-  ~Comment() {
-    if (msg_[0] == '[') __ RecordComment("]");
-  }
-
- private:
-  MacroAssembler* masm_;
-  const char* msg_;
-};
-
-#else
-
-class Comment BASE_EMBEDDED {
- public:
-  Comment(MacroAssembler*, const char*)  {}
-};
-
-#endif  // DEBUG
-
-#undef __
-
-
 } }  // namespace v8::internal
 
 #endif  // V8_CODEGEN_INL_H_

diff --git a/src/codegen.cc b/src/codegen.cc
index ef5e982b07fa6c5a23a2adf96301b9e540a7f1e9..24eb47629450d927f543e7419120de7a2f601780 100644 (file)
--- a/src/codegen.cc
+++ b/src/codegen.cc
@@ -42,6 +42,24 @@
 namespace v8 {
 namespace internal {
 
+#define __ ACCESS_MASM(masm_)
+
+#ifdef DEBUG
+
+Comment::Comment(MacroAssembler* masm, const char* msg)
+    : masm_(masm), msg_(msg) {
+  __ RecordComment(msg);
+}
+
+
+Comment::~Comment() {
+  if (msg_[0] == '[') __ RecordComment("]");
+}
+
+#endif  // DEBUG
+
+#undef __
+
 
 CodeGenerator* CodeGeneratorScope::top_ = NULL;
 

diff --git a/src/codegen.h b/src/codegen.h
index 5a143bc2722a8c8bcb924e14bcff56338a1abf8b..3afa04146c887a8d335c76d28172592fad3e4973 100644 (file)
--- a/src/codegen.h
+++ b/src/codegen.h
@@ -98,6 +98,29 @@ namespace v8 {
 namespace internal {
 
 
+// Support for "structured" code comments.
+#ifdef DEBUG
+
+class Comment BASE_EMBEDDED {
+ public:
+  Comment(MacroAssembler* masm, const char* msg);
+  ~Comment();
+
+ private:
+  MacroAssembler* masm_;
+  const char* msg_;
+};
+
+#else
+
+class Comment BASE_EMBEDDED {
+ public:
+  Comment(MacroAssembler*, const char*)  {}
+};
+
+#endif  // DEBUG
+
+
 // Code generation can be nested.  Code generation scopes form a stack
 // of active code generators.
 class CodeGeneratorScope BASE_EMBEDDED {