net: dpaa2: use pcs-lynx's check for fwnode availability
authorRussell King (Oracle) <rmk+kernel@armlinux.org.uk>
Wed, 7 Jun 2023 11:58:59 +0000 (12:58 +0100)
committerJakub Kicinski <kuba@kernel.org>
Fri, 9 Jun 2023 02:19:50 +0000 (19:19 -0700)
Use pcs-lynx's check rather than our own when determining if the device
is available.

Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c

index 38e6208..d860d9f 100644 (file)
@@ -257,12 +257,6 @@ static int dpaa2_pcs_create(struct dpaa2_mac *mac,
                return 0;
        }
 
-       if (!fwnode_device_is_available(node)) {
-               netdev_err(mac->net_dev, "pcs-handle node not available\n");
-               fwnode_handle_put(node);
-               return -ENODEV;
-       }
-
        pcs = lynx_pcs_create_fwnode(node);
        fwnode_handle_put(node);
 
@@ -271,6 +265,11 @@ static int dpaa2_pcs_create(struct dpaa2_mac *mac,
                return -EPROBE_DEFER;
        }
 
+       if (pcs == ERR_PTR(-ENODEV)) {
+               netdev_err(mac->net_dev, "pcs-handle node not available\n");
+               return PTR_ERR(pcs);
+       }
+
        if (IS_ERR(pcs)) {
                netdev_err(mac->net_dev,
                           "lynx_pcs_create_fwnode() failed: %pe\n", pcs);