ALSA: hda: Add IRQ check for platform_get_irq()
authorJiajun Cao <jjcao20@fudan.edu.cn>
Tue, 22 Jun 2021 13:19:42 +0000 (21:19 +0800)
committerTakashi Iwai <tiwai@suse.de>
Tue, 22 Jun 2021 14:12:03 +0000 (16:12 +0200)
The function hda_tegra_first_init() neglects to check the return
value after executing platform_get_irq().

hda_tegra_first_init() should check the return value (if negative
error number) for errors so as to not pass a negative value to
the devm_request_irq().

Fix it by adding a check for the return value irq_id.

Signed-off-by: Jiajun Cao <jjcao20@fudan.edu.cn>
Signed-off-by: Xin Tan <tanxin.ctf@gmail.com>
Reviewed-by: Thierry Reding <treding@nvidia.com>
Link: https://lore.kernel.org/r/20210622131947.94346-1-jjcao20@fudan.edu.cn
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/hda/hda_tegra.c

index 5aeef61..ea70039 100644 (file)
@@ -260,6 +260,9 @@ static int hda_tegra_first_init(struct azx *chip, struct platform_device *pdev)
        const char *sname, *drv_name = "tegra-hda";
        struct device_node *np = pdev->dev.of_node;
 
+       if (irq_id < 0)
+               return irq_id;
+
        err = hda_tegra_init_chip(chip, pdev);
        if (err)
                return err;