drm/amd/display: Remove redundant vblank workqueues in DM
authorRoman Li <Roman.Li@amd.com>
Fri, 16 Jul 2021 21:22:06 +0000 (17:22 -0400)
committerAlex Deucher <alexander.deucher@amd.com>
Fri, 6 Aug 2021 01:17:58 +0000 (21:17 -0400)
[Why]
Display Manager initializes array of vblank workqueues, but only 1 is used.

[How]
Use single instance init instead of array.

Reviewed-by: Qingqing Zhou <Qingqing.Zhuo@amd.com>
Acked-by: Aurabindo Pillai <aurabindo.pillai@amd.com>
Signed-off-by: Roman Li <Roman.Li@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c

index 986c9d2..1d9aed2 100644 (file)
@@ -1066,19 +1066,15 @@ static void event_mall_stutter(struct work_struct *work)
 
 static struct vblank_workqueue *vblank_create_workqueue(struct amdgpu_device *adev, struct dc *dc)
 {
-
-       int max_caps = dc->caps.max_links;
        struct vblank_workqueue *vblank_work;
-       int i = 0;
 
-       vblank_work = kcalloc(max_caps, sizeof(*vblank_work), GFP_KERNEL);
+       vblank_work = kzalloc(sizeof(*vblank_work), GFP_KERNEL);
        if (ZERO_OR_NULL_PTR(vblank_work)) {
                kfree(vblank_work);
                return NULL;
        }
 
-       for (i = 0; i < max_caps; i++)
-               INIT_WORK(&vblank_work[i].mall_work, event_mall_stutter);
+       INIT_WORK(&vblank_work->mall_work, event_mall_stutter);
 
        return vblank_work;
 }