From: Arvind R <arvino55@gmail.com>

Subject: Re: [e-users] 3 small corrections in elc_player

Hi,
1. remove __UNUSED__ for parameter that is used.
2. emit a "elm,player,play" signal as is done in _pause to keep the
state of pause/play buttons in sync.
3. Correct double_to_string which misses out subtracting hours to get
seconds.

SVN revision: 83855

diff --git a/legacy/elementary/AUTHORS b/legacy/elementary/AUTHORS
index 4a9ec07..94f5e00 100644 (file)
--- a/legacy/elementary/AUTHORS
+++ b/legacy/elementary/AUTHORS
@@ -75,3 +75,4 @@ Gwanglim Lee <gl77.lee@samsung.com> <gwanglim@gmail.com>
 JaeHyun Jo <jae_hyun_cho@naver.com>
 Bora Hwang <bora1.hwang@samsung.com>
 Jiyoung Choi <jychoi7.choi@samsung.com>
+Arvind R <arvino55@gmail.com>

diff --git a/legacy/elementary/ChangeLog b/legacy/elementary/ChangeLog
index 0a69ebc..640a7e9 100644 (file)
--- a/legacy/elementary/ChangeLog
+++ b/legacy/elementary/ChangeLog
@@ -985,14 +985,19 @@
 
         * Add smart callback signals of a scroller. "vbar,drag", "vbar,press", "vbar,unpress", "hbar,drag", "hbar,press", "hbar,unpress".
 
-2013-02-13  ChunEon Park (Hermet)
+2013-02-12  ChunEon Park (Hermet)
 
         * GLview, Gengrid support "language,changed" smart callback.
 
-2013-02-13  ChunEon Park (Hermet)
+2013-02-12  ChunEon Park (Hermet)
 
         * Ctxpopup will be dismissed when elm language is changed.
 
-2013-02-13  ChunEon Park (Hermet)
+2013-02-12  ChunEon Park (Hermet)
 
         * added APIs - elm_object_item_translatable_part_text_set(), elm_object_item_translatable_part_text_get().
+
+2013-02-12  Arvind R
+
+        * Fix elc_player pause state to be in sync.
+        * Fix time string display to handle hours right.

diff --git a/legacy/elementary/NEWS b/legacy/elementary/NEWS
index d5f1098..ef4b132 100644 (file)
--- a/legacy/elementary/NEWS
+++ b/legacy/elementary/NEWS
@@ -141,6 +141,8 @@ Fixes:
    * Apply disply mode to all views of a naviframe if the display mode of the views are changed. Sometimes views are couldn't be recoverved to a previous status if they are stacked into more depth.
    * Fix the scroll position is calculated by the size of pan object, not the size of scroller.
    * Fix a elm_transit crash issue when user delete all target objects in the effect end callback.
+   * Fix elc_player pause state to be in sync
+   * Fix time string display to handle hours right
 
 Removals:
 

diff --git a/legacy/elementary/src/lib/elc_player.c b/legacy/elementary/src/lib/elc_player.c
index 876de49..02527f7 100644 (file)
--- a/legacy/elementary/src/lib/elc_player.c
+++ b/legacy/elementary/src/lib/elc_player.c
@@ -279,6 +279,7 @@ _play(void *data,
 {
    ELM_PLAYER_DATA_GET(data, sd);
 
+   elm_layout_signal_emit(data, "elm,player,play", "elm");
    elm_video_play(sd->video);
    elm_layout_signal_emit(data, "elm,button,play", "elm");
    evas_object_smart_callback_call(data, SIG_PLAY_CLICKED, NULL);
@@ -401,7 +402,7 @@ _double_to_time(double value)
 
    ph = value / 3600;
    pm = value / 60 - (ph * 60);
-   ps = value - (pm * 60);
+   ps = value - (pm * 60) - (ph * 3600);
    pf = value * 100 - (ps * 100) - (pm * 60 * 100) - (ph * 60 * 60 * 100);
 
    if (ph)
@@ -428,7 +429,7 @@ _str_free(char *data)
  * layout */
 
 static void
-_elm_player_smart_content_set(Eo *obj, void *_pd EINA_UNUSED, va_list *list)
+_elm_player_smart_content_set(Eo *obj, void *_pd, va_list *list)
 {
    const char *part = va_arg(*list, const char *);
    Evas_Object *content = va_arg(*list, Evas_Object *);