media: bttv: use semicolons rather than commas to separate statements
authorJulia Lawall <Julia.Lawall@inria.fr>
Tue, 29 Sep 2020 13:14:43 +0000 (15:14 +0200)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Mon, 16 Nov 2020 09:31:07 +0000 (10:31 +0100)
Replace commas with semicolons.  Commas introduce unnecessary
variability in the code structure and are hard to see.  What is done
is essentially described by the following Coccinelle semantic patch
(http://coccinelle.lip6.fr/):

// <smpl>
@@ expression e1,e2; @@
e1
-,
+;
e2
... when any
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/pci/bt8xx/bttv-cards.c

index 1614880..ca20b80 100644 (file)
@@ -3934,8 +3934,10 @@ static void osprey_eeprom(struct bttv *btv, const u8 ee[256])
                        if (checksum != ee[21])
                                return;
                        cardid = BTTV_BOARD_OSPREY1x0_848;
-                       for (i = 12; i < 21; i++)
-                               serial *= 10, serial += ee[i] - '0';
+                       for (i = 12; i < 21; i++) {
+                               serial *= 10;
+                               serial += ee[i] - '0';
+                       }
                }
        } else {
                unsigned short type;