perf c2c: Support memory event PERF_MEM_EVENTS__LOAD_STORE
authorLeo Yan <leo.yan@linaro.org>
Fri, 6 Nov 2020 09:48:48 +0000 (17:48 +0800)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Wed, 11 Nov 2020 15:23:53 +0000 (12:23 -0300)
When user doesn't specify event name, perf c2c tool enables both the
load and store events, and this leads to failure for opening the
duplicate PMU device for AUX trace.

After the memory event PERF_MEM_EVENTS__LOAD_STORE is introduced, when
the user doesn't specify event name, this patch converts the required
operation to PERF_MEM_EVENTS__LOAD_STORE if the arch supports it.
Otherwise, the tool still rolls back to enable events
PERF_MEM_EVENTS__LOAD and PERF_MEM_EVENTS__STORE.

Signed-off-by: Leo Yan <leo.yan@linaro.org>
Acked-by: Jiri Olsa <jolsa@redhat.com>
Link: https://lore.kernel.org/r/20201106094853.21082-5-leo.yan@linaro.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/builtin-c2c.c

index 4d1a08e..98ae33e 100644 (file)
@@ -2895,11 +2895,20 @@ static int perf_c2c__record(int argc, const char **argv)
        rec_argv[i++] = "record";
 
        if (!event_set) {
-               e = perf_mem_events__ptr(PERF_MEM_EVENTS__LOAD);
-               e->record = true;
+               e = perf_mem_events__ptr(PERF_MEM_EVENTS__LOAD_STORE);
+               /*
+                * The load and store operations are required, use the event
+                * PERF_MEM_EVENTS__LOAD_STORE if it is supported.
+                */
+               if (e->tag) {
+                       e->record = true;
+               } else {
+                       e = perf_mem_events__ptr(PERF_MEM_EVENTS__LOAD);
+                       e->record = true;
 
-               e = perf_mem_events__ptr(PERF_MEM_EVENTS__STORE);
-               e->record = true;
+                       e = perf_mem_events__ptr(PERF_MEM_EVENTS__STORE);
+                       e->record = true;
+               }
        }
 
        e = perf_mem_events__ptr(PERF_MEM_EVENTS__LOAD);