mmc: core: Only change mode if mmc_select_bus_width() is successful
authorPeter Griffin <peter.griffin@linaro.org>
Wed, 8 Jun 2016 10:27:52 +0000 (11:27 +0100)
committerUlf Hansson <ulf.hansson@linaro.org>
Mon, 25 Jul 2016 08:34:12 +0000 (10:34 +0200)
mmc_select_bus_width() returns bus width (4 or 8) on success or
zero if unsupported. So only change mode if setting the bus width
is successful.

Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/core/mmc.c

index 900b9f9..ccab9bb 100644 (file)
@@ -1334,7 +1334,7 @@ static int mmc_select_hs200(struct mmc_card *card)
         * switch to HS200 mode if bus width is set successfully.
         */
        err = mmc_select_bus_width(card);
-       if (err >= 0) {
+       if (err > 0) {
                val = EXT_CSD_TIMING_HS200 |
                      card->drive_strength << EXT_CSD_DRV_STR_SHIFT;
                err = __mmc_switch(card, EXT_CSD_CMD_SET_NORMAL,
@@ -1642,7 +1642,7 @@ static int mmc_init_card(struct mmc_host *host, u32 ocr,
        } else if (mmc_card_hs(card)) {
                /* Select the desired bus width optionally */
                err = mmc_select_bus_width(card);
-               if (err >= 0) {
+               if (err > 0) {
                        err = mmc_select_hs_ddr(card);
                        if (err)
                                goto free_card;