inet_connection_sock: remove unused parameter of reqsk_queue_unlink func
authorZhiqiang Liu <liuzhiqiang26@huawei.com>
Wed, 5 Jun 2019 10:49:49 +0000 (18:49 +0800)
committerDavid S. Miller <davem@davemloft.net>
Thu, 6 Jun 2019 01:48:49 +0000 (18:48 -0700)
small cleanup: "struct request_sock_queue *queue" parameter of reqsk_queue_unlink
func is never used in the func, so we can remove it.

Signed-off-by: Zhiqiang Liu <liuzhiqiang26@huawei.com>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/inet_connection_sock.c

index a175e3e..474e157 100644 (file)
@@ -653,8 +653,7 @@ int inet_rtx_syn_ack(const struct sock *parent, struct request_sock *req)
 EXPORT_SYMBOL(inet_rtx_syn_ack);
 
 /* return true if req was found in the ehash table */
-static bool reqsk_queue_unlink(struct request_sock_queue *queue,
-                              struct request_sock *req)
+static bool reqsk_queue_unlink(struct request_sock *req)
 {
        struct inet_hashinfo *hashinfo = req_to_sk(req)->sk_prot->h.hashinfo;
        bool found = false;
@@ -673,7 +672,7 @@ static bool reqsk_queue_unlink(struct request_sock_queue *queue,
 
 void inet_csk_reqsk_queue_drop(struct sock *sk, struct request_sock *req)
 {
-       if (reqsk_queue_unlink(&inet_csk(sk)->icsk_accept_queue, req)) {
+       if (reqsk_queue_unlink(req)) {
                reqsk_queue_removed(&inet_csk(sk)->icsk_accept_queue, req);
                reqsk_put(req);
        }