media: staging: atomisp: don't access a NULL var
authorMauro Carvalho Chehab <mchehab@s-opensource.com>
Mon, 26 Mar 2018 18:54:47 +0000 (14:54 -0400)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Wed, 4 Apr 2018 11:36:27 +0000 (07:36 -0400)
Get rid of those warnings:
drivers/staging/media/atomisp/platform/intel-mid/atomisp_gmin_platform.c:446 gmin_v1p2_ctrl() error: we previously assumed 'gs' could be null (see line 444)
drivers/staging/media/atomisp/platform/intel-mid/atomisp_gmin_platform.c:480 gmin_v1p8_ctrl() error: we previously assumed 'gs' could be null (see line 478)
drivers/staging/media/atomisp/platform/intel-mid/atomisp_gmin_platform.c:516 gmin_v2p8_ctrl() error: we previously assumed 'gs' could be null (see line 514)

Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/staging/media/atomisp/platform/intel-mid/atomisp_gmin_platform.c

index d8b7183..be0c5e1 100644 (file)
@@ -441,7 +441,7 @@ static int gmin_v1p2_ctrl(struct v4l2_subdev *subdev, int on)
 {
        struct gmin_subdev *gs = find_gmin_subdev(subdev);
 
-       if (gs && gs->v1p2_on == on)
+       if (!gs || gs->v1p2_on == on)
                return 0;
        gs->v1p2_on = on;
 
@@ -475,7 +475,7 @@ static int gmin_v1p8_ctrl(struct v4l2_subdev *subdev, int on)
                }
        }
 
-       if (gs && gs->v1p8_on == on)
+       if (!gs || gs->v1p8_on == on)
                return 0;
        gs->v1p8_on = on;
 
@@ -511,7 +511,7 @@ static int gmin_v2p8_ctrl(struct v4l2_subdev *subdev, int on)
                }
        }
 
-       if (gs && gs->v2p8_on == on)
+       if (!gs || gs->v2p8_on == on)
                return 0;
        gs->v2p8_on = on;