gpiolib: fix OOB access in quirk callbacks
authorMichael Walle <michael@walle.cc>
Fri, 16 Sep 2022 11:01:18 +0000 (13:01 +0200)
committerBartosz Golaszewski <brgl@bgdev.pl>
Tue, 20 Sep 2022 06:30:57 +0000 (08:30 +0200)
Commit a2b5e207cade ("gpiolib: rework quirk handling in of_find_gpio()")
introduced an array of quirk functions which get iterated over. But a
sentinal value is missing. Add it.

Fixes: a2b5e207cade ("gpiolib: rework quirk handling in of_find_gpio()")
Signed-off-by: Michael Walle <michael@walle.cc>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Tested-by: Conor Dooley <conor.dooley@microchip.com>
Reviewed-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>
Tested-by: Biju Das <biju.das.jz@bp.renesas.com>
Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
drivers/gpio/gpiolib-of.c

index 95be5f0..0e4e129 100644 (file)
@@ -498,6 +498,7 @@ static const of_find_gpio_quirk of_find_gpio_quirks[] = {
        of_find_regulator_gpio,
        of_find_arizona_gpio,
        of_find_usb_gpio,
+       NULL
 };
 
 struct gpio_desc *of_find_gpio(struct device *dev, const char *con_id,