mfd: properly handle platform_device_add_resources fail in mfd_add_device
authorAxel Lin <axel.lin@gmail.com>
Mon, 31 May 2010 09:30:55 +0000 (17:30 +0800)
committerSamuel Ortiz <sameo@linux.intel.com>
Thu, 12 Aug 2010 09:27:19 +0000 (11:27 +0200)
platform_device_add_resources may fail, thus add error checking for it.

Signed-off-by: Axel Lin <axel.lin@gmail.com>
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
drivers/mfd/mfd-core.c

index 7dd76bc..1823a57 100644 (file)
@@ -70,7 +70,9 @@ static int mfd_add_device(struct device *parent, int id,
                        goto fail_res;
        }
 
-       platform_device_add_resources(pdev, res, cell->num_resources);
+       ret = platform_device_add_resources(pdev, res, cell->num_resources);
+       if (ret)
+               goto fail_res;
 
        ret = platform_device_add(pdev);
        if (ret)