drm/virtio: use strscpy() to instead of strncpy()
authorXu Panda <xu.panda@zte.com.cn>
Wed, 7 Dec 2022 01:13:16 +0000 (09:13 +0800)
committerDmitry Osipenko <dmitry.osipenko@collabora.com>
Sun, 26 Feb 2023 23:58:50 +0000 (02:58 +0300)
The implementation of strscpy() is more robust and safer.
That's now the recommended way to copy NUL terminated strings.

Signed-off-by: Xu Panda <xu.panda@zte.com.cn>
Signed-off-by: Yang Yang <yang.yang29@zte.com>
Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
Link: https://patchwork.freedesktop.org/patch/msgid/202212070913161959936@zte.com.cn
drivers/gpu/drm/virtio/virtgpu_vq.c

index a04a9b2..e1accfc 100644 (file)
@@ -923,8 +923,7 @@ void virtio_gpu_cmd_context_create(struct virtio_gpu_device *vgdev, uint32_t id,
        cmd_p->hdr.ctx_id = cpu_to_le32(id);
        cmd_p->nlen = cpu_to_le32(nlen);
        cmd_p->context_init = cpu_to_le32(context_init);
-       strncpy(cmd_p->debug_name, name, sizeof(cmd_p->debug_name) - 1);
-       cmd_p->debug_name[sizeof(cmd_p->debug_name) - 1] = 0;
+       strscpy(cmd_p->debug_name, name, sizeof(cmd_p->debug_name));
        virtio_gpu_queue_ctrl_buffer(vgdev, vbuf);
 }