[Tizen] Fix mGestureRecognizer leak 16/244016/1
authorHeeyong Song <heeyong.song@samsung.com>
Wed, 29 Jul 2020 02:26:06 +0000 (11:26 +0900)
committerHeeyong Song <heeyong.song@samsung.com>
Mon, 14 Sep 2020 06:06:31 +0000 (15:06 +0900)
IntrusivePtr::Detach doesn't decrease the reference count. So mGestureRecognizer isn't deleted.

Change-Id: Id923e1be0e2646a74c70ec998b2fcab95641035d

dali/internal/event/events/long-press-gesture/long-press-gesture-processor.cpp
dali/internal/event/events/pan-gesture/pan-gesture-processor.cpp
dali/internal/event/events/pinch-gesture/pinch-gesture-processor.cpp
dali/internal/event/events/rotation-gesture/rotation-gesture-processor.cpp
dali/internal/event/events/tap-gesture/tap-gesture-processor.cpp

index b707e24..e0c4a5d 100644 (file)
@@ -252,7 +252,7 @@ void LongPressGestureProcessor::RemoveGestureDetector( LongPressGestureDetector*
 
   if ( mLongPressGestureDetectors.empty() )
   {
-    mGestureRecognizer.Detach();
+    mGestureRecognizer = nullptr;
   }
   else
   {
index 51bef8d..7110929 100644 (file)
@@ -320,7 +320,7 @@ void PanGestureProcessor::RemoveGestureDetector( PanGestureDetector* gestureDete
 
   if (mPanGestureDetectors.empty())
   {
-    mGestureRecognizer.Detach();
+    mGestureRecognizer = nullptr;
   }
   else
   {
index c373fae..0fb287e 100644 (file)
@@ -250,7 +250,7 @@ void PinchGestureProcessor::RemoveGestureDetector( PinchGestureDetector* gesture
 
   if (mPinchGestureDetectors.empty())
   {
-    mGestureRecognizer.Detach();
+    mGestureRecognizer = nullptr;
   }
 }
 
index f65642e..9f1e647 100644 (file)
@@ -224,7 +224,7 @@ void RotationGestureProcessor::RemoveGestureDetector( RotationGestureDetector* g
 
   if (mRotationGestureDetectors.empty())
   {
-    mGestureRecognizer.Detach();
+    mGestureRecognizer = nullptr;
   }
 }
 
index f003812..cf74b6f 100644 (file)
@@ -223,7 +223,7 @@ void TapGestureProcessor::RemoveGestureDetector( TapGestureDetector* gestureDete
 
   if ( mTapGestureDetectors.empty() )
   {
-    mGestureRecognizer.Detach();
+    mGestureRecognizer = nullptr;
 
     ResetActor();
   }