clang-cl pch test: Instead of copying the input, use /Fp to not write into the test...

Also fix a bug with /Fp and absolute paths uncovered by this.
Follow-up to r262487.

llvm-svn: 262541

diff --git a/clang/lib/Driver/Driver.cpp b/clang/lib/Driver/Driver.cpp
index 8965d3d6c3c5591591e7917b1c47b592e69ddf86..f8d6fc7770ac1c29a14907e08980b51a145100b1 100644 (file)
--- a/clang/lib/Driver/Driver.cpp
+++ b/clang/lib/Driver/Driver.cpp
@@ -2246,7 +2246,7 @@ const char *Driver::GetNamedOutputPath(Compilation &C, const JobAction &JA,
   }
 
   // As an annoying special case, PCH generation doesn't strip the pathname.
-  if (JA.getType() == types::TY_PCH) {
+  if (JA.getType() == types::TY_PCH && !IsCLMode()) {
     llvm::sys::path::remove_filename(BasePath);
     if (BasePath.empty())
       BasePath = NamedOutput;

diff --git a/clang/test/Driver/cl-pch-errorhandling.cpp b/clang/test/Driver/cl-pch-errorhandling.cpp
index 41fcfbef0f34b9c4c697920965cc036d0b0d266d..ec06bb5240001322a9e2365aefe4d8a83a54e594 100644 (file)
--- a/clang/test/Driver/cl-pch-errorhandling.cpp
+++ b/clang/test/Driver/cl-pch-errorhandling.cpp
@@ -6,8 +6,7 @@
 // code generation, which makes this test require an x86 backend.
 // REQUIRES: x86-registered-target
 
-// RUN: cp %S/Inputs/pchfile.h %t.h
-// RUN: not %clang_cl -internal-enable-pch -Werror /Yc%t.h /FI%t.h /c -DERR_HEADER -- %s 2>&1 \
+// RUN: not %clang_cl -internal-enable-pch -Werror /Yc%S/Inputs/pchfile.h /FI%S/Inputs/pchfile.h /Fp%t.pch /c -DERR_HEADER -- %s 2>&1 \
 // RUN:   | FileCheck %s
 
 // CHECK: nope1