leds: rt8515: Put fwnode in any case during ->probe()
authorAndy Shevchenko <andy.shevchenko@gmail.com>
Sat, 29 May 2021 11:19:34 +0000 (14:19 +0300)
committerPavel Machek <pavel@ucw.cz>
Tue, 3 Aug 2021 21:49:37 +0000 (23:49 +0200)
fwnode_get_next_available_child_node() bumps a reference counting of
a returned variable. We have to balance it whenever we return to
the caller.

Fixes: e1c6edcbea13 ("leds: rt8515: Add Richtek RT8515 LED driver")
Signed-off-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Pavel Machek <pavel@ucw.cz>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
drivers/leds/flash/leds-rt8515.c

index 590bfa1..44904fd 100644 (file)
@@ -343,8 +343,9 @@ static int rt8515_probe(struct platform_device *pdev)
 
        ret = devm_led_classdev_flash_register_ext(dev, fled, &init_data);
        if (ret) {
-               dev_err(dev, "can't register LED %s\n", led->name);
+               fwnode_handle_put(child);
                mutex_destroy(&rt->lock);
+               dev_err(dev, "can't register LED %s\n", led->name);
                return ret;
        }
 
@@ -362,6 +363,7 @@ static int rt8515_probe(struct platform_device *pdev)
                 */
        }
 
+       fwnode_handle_put(child);
        return 0;
 }