net: hns3: fix sparse: warning when calling hclge_set_vlan_filter_hw()
authorJian Shen <shenjian15@huawei.com>
Mon, 15 Apr 2019 13:48:38 +0000 (21:48 +0800)
committerDavid S. Miller <davem@davemloft.net>
Mon, 15 Apr 2019 20:39:19 +0000 (13:39 -0700)
The input parameter "proto" in function hclge_set_vlan_filter_hw()
is asked to be __be16, but got u16 when calling it in function
hclge_update_port_base_vlan_cfg().

This patch fixes it by converting it with htons().

Reported-by: kbuild test robot <lkp@intel.com>
Fixes: 21e043cd8124 ("net: hns3: fix set port based VLAN for PF")
Signed-off-by: Jian Shen <shenjian15@huawei.com>
Signed-off-by: Huazhong Tan <tanhuazhong@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c

index d2fb548..7dba3b4 100644 (file)
@@ -6964,7 +6964,8 @@ int hclge_update_port_base_vlan_cfg(struct hclge_vport *vport, u16 state,
 
        if (state == HNAE3_PORT_BASE_VLAN_MODIFY) {
                /* add new VLAN tag */
-               ret = hclge_set_vlan_filter_hw(hdev, vlan_info->vlan_proto,
+               ret = hclge_set_vlan_filter_hw(hdev,
+                                              htons(vlan_info->vlan_proto),
                                               vport->vport_id,
                                               vlan_info->vlan_tag,
                                               vlan_info->qos, false);
@@ -6972,7 +6973,8 @@ int hclge_update_port_base_vlan_cfg(struct hclge_vport *vport, u16 state,
                        return ret;
 
                /* remove old VLAN tag */
-               ret = hclge_set_vlan_filter_hw(hdev, old_vlan_info->vlan_proto,
+               ret = hclge_set_vlan_filter_hw(hdev,
+                                              htons(old_vlan_info->vlan_proto),
                                               vport->vport_id,
                                               old_vlan_info->vlan_tag,
                                               old_vlan_info->qos, true);