staging: r8188eu: update status before link blinking
authorMartin Kaiser <martin@kaiser.cx>
Sun, 11 Sep 2022 14:51:22 +0000 (16:51 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 24 Sep 2022 11:07:49 +0000 (13:07 +0200)
Always update the status variables in rtw_led_control when we start link
blinking. The if statements are not necessary.

Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> # Edimax N150
Signed-off-by: Martin Kaiser <martin@kaiser.cx>
Link: https://lore.kernel.org/r/20220911145122.15444-10-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/r8188eu/core/rtw_led.c

index 0881c81..98eebe3 100644 (file)
@@ -244,13 +244,11 @@ void rtw_led_control(struct adapter *padapter, enum LED_CTL_MODE LedAction)
                        return;
 
                cancel_delayed_work(&pLed->blink_work);
-               if (pLed->bLedNoLinkBlinkInProgress)
-                       pLed->bLedNoLinkBlinkInProgress = false;
-
-               if (pLed->bLedBlinkInProgress)
-                       pLed->bLedBlinkInProgress = false;
 
+               pLed->bLedNoLinkBlinkInProgress = false;
+               pLed->bLedBlinkInProgress = false;
                pLed->bLedLinkBlinkInProgress = true;
+
                pLed->CurrLedState = LED_BLINK_NORMAL;
                if (pLed->bLedOn)
                        pLed->BlinkingLedState = RTW_LED_OFF;