ACPI: properties: Consistently return -ENOENT if there are no more references
authorSakari Ailus <sakari.ailus@linux.intel.com>
Fri, 14 Jan 2022 11:24:49 +0000 (13:24 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 8 Apr 2022 12:22:58 +0000 (14:22 +0200)
commit babc92da5928f81af951663fc436997352e02d3a upstream.

__acpi_node_get_property_reference() is documented to return -ENOENT if
the caller requests a property reference at an index that does not exist,
not -EINVAL which it actually does.

Fix this by returning -ENOENT consistenly, independently of whether the
property value is a plain reference or a package.

Fixes: c343bc2ce2c6 ("ACPI: properties: Align return codes of __acpi_node_get_property_reference()")
Cc: 4.14+ <stable@vger.kernel.org> # 4.14+
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/acpi/property.c

index 781e312..11e4c93 100644 (file)
@@ -685,7 +685,7 @@ int __acpi_node_get_property_reference(const struct fwnode_handle *fwnode,
         */
        if (obj->type == ACPI_TYPE_LOCAL_REFERENCE) {
                if (index)
-                       return -EINVAL;
+                       return -ENOENT;
 
                ret = acpi_bus_get_device(obj->reference.handle, &device);
                if (ret)