bpf: fix inconsistent return types of bpf_xdp_copy_buf().
authorKui-Feng Lee <thinker.li@gmail.com>
Fri, 4 Aug 2023 00:51:01 +0000 (17:51 -0700)
committerMartin KaFai Lau <martin.lau@kernel.org>
Fri, 4 Aug 2023 21:38:31 +0000 (14:38 -0700)
Fix inconsistent return types in two implementations of bpf_xdp_copy_buf().

There are two implementations: one is an empty implementation whose return
type does not match the actual implementation.

Suggested-by: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Signed-off-by: Kui-Feng Lee <thinker.li@gmail.com>
Acked-by: Yonghong Song <yonghong.song@linux.dev>
Link: https://lore.kernel.org/r/20230804005101.1534505-1-thinker.li@gmail.com
Signed-off-by: Martin KaFai Lau <martin.lau@kernel.org>
include/linux/filter.h

index 2d6fe30..761af6b 100644 (file)
@@ -1572,10 +1572,9 @@ static inline void *bpf_xdp_pointer(struct xdp_buff *xdp, u32 offset, u32 len)
        return NULL;
 }
 
-static inline void *bpf_xdp_copy_buf(struct xdp_buff *xdp, unsigned long off, void *buf,
-                                    unsigned long len, bool flush)
+static inline void bpf_xdp_copy_buf(struct xdp_buff *xdp, unsigned long off, void *buf,
+                                   unsigned long len, bool flush)
 {
-       return NULL;
 }
 #endif /* CONFIG_NET */