middle-end/107679 - fix SSA rewrite of clobber of parameter
authorRichard Biener <rguenther@suse.de>
Wed, 16 Nov 2022 12:57:14 +0000 (13:57 +0100)
committerRichard Biener <rguenther@suse.de>
Wed, 16 Nov 2022 16:07:39 +0000 (17:07 +0100)
When the frontend clobbers a parameter and that parameter gets
rewritten into SSA then we ICE because we didn't expect this.  Avoid
using the parameter decl to create a SSA default def in this case.

PR middle-end/107679
* tree-into-ssa.cc (maybe_register_def): Use new temporary if
we require an uninitialized value for a parameter decl.

* gfortran.dg/pr107679.f90: New testcase.

gcc/testsuite/gfortran.dg/pr107679.f90 [new file with mode: 0644]
gcc/tree-into-ssa.cc

diff --git a/gcc/testsuite/gfortran.dg/pr107679.f90 b/gcc/testsuite/gfortran.dg/pr107679.f90
new file mode 100644 (file)
index 0000000..33a52fb
--- /dev/null
@@ -0,0 +1,9 @@
+! { dg-do compile }
+
+subroutine s1(x)
+   integer, intent(out) :: x
+end
+subroutine s2(z)
+   integer, value :: z
+   call s1(z)
+end
index d13fb72..f21ed2b 100644 (file)
@@ -1911,13 +1911,17 @@ maybe_register_def (def_operand_p def_p, gimple *stmt,
        {
          if (gimple_clobber_p (stmt) && is_gimple_reg (sym))
            {
-             gcc_checking_assert (VAR_P (sym));
+             tree defvar;
+             if (VAR_P (sym))
+               defvar = sym;
+             else
+               defvar = create_tmp_reg (TREE_TYPE (sym));
              /* Replace clobber stmts with a default def. This new use of a
                 default definition may make it look like SSA_NAMEs have
                 conflicting lifetimes, so we need special code to let them
                 coalesce properly.  */
              to_delete = true;
-             def = get_or_create_ssa_default_def (cfun, sym);
+             def = get_or_create_ssa_default_def (cfun, defvar);
            }
          else
            {