pstore/platform: fix potential mem leak if pstore_init_fs failed
authorchenqiwu <chenqiwu@xiaomi.com>
Fri, 7 Feb 2020 09:46:39 +0000 (17:46 +0800)
committerKees Cook <keescook@chromium.org>
Tue, 25 Feb 2020 19:13:18 +0000 (11:13 -0800)
There is a potential mem leak when pstore_init_fs failed,
since the pstore compression maybe unlikey to initialized
successfully. We must clean up the allocation once this
unlikey issue happens.

Signed-off-by: chenqiwu <chenqiwu@xiaomi.com>
Link: https://lore.kernel.org/r/1581068800-13817-1-git-send-email-qiwuchen55@gmail.com
Signed-off-by: Kees Cook <keescook@chromium.org>
fs/pstore/platform.c

index d896457..408277e 100644 (file)
@@ -823,9 +823,9 @@ static int __init pstore_init(void)
 
        ret = pstore_init_fs();
        if (ret)
-               return ret;
+               free_buf_for_compression();
 
-       return 0;
+       return ret;
 }
 late_initcall(pstore_init);