net/mlx5: Use system_image_guid to determine bonding
authorRongwei Liu <rongweil@nvidia.com>
Tue, 12 Oct 2021 07:53:00 +0000 (10:53 +0300)
committerSaeed Mahameed <saeedm@nvidia.com>
Sat, 16 Oct 2021 00:37:47 +0000 (17:37 -0700)
With specific NICs, the PFs may have different PCIe ids like
0001:01:00.0/1 and 0002:02:00:00/1.

For PFs with the same system_image_guid, driver should consider
them under the same physical NIC and they are legal to bond together.

If firmware doesn't support system_image_guid, set it to zero and
fallback to use PCIe ids.

Signed-off-by: Rongwei Liu <rongweil@nvidia.com>
Reviewed-by: Mark Bloch <mbloch@nvidia.com>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
drivers/net/ethernet/mellanox/mlx5/core/dev.c

index e8093c4..a8b84d5 100644 (file)
@@ -33,6 +33,7 @@
 #include <linux/mlx5/driver.h>
 #include <linux/mlx5/eswitch.h>
 #include <linux/mlx5/mlx5_ifc_vdpa.h>
+#include <linux/mlx5/vport.h>
 #include "mlx5_core.h"
 
 /* intf dev list mutex */
@@ -537,6 +538,16 @@ int mlx5_rescan_drivers_locked(struct mlx5_core_dev *dev)
        return add_drivers(dev);
 }
 
+static bool mlx5_same_hw_devs(struct mlx5_core_dev *dev, struct mlx5_core_dev *peer_dev)
+{
+       u64 fsystem_guid, psystem_guid;
+
+       fsystem_guid = mlx5_query_nic_system_image_guid(dev);
+       psystem_guid = mlx5_query_nic_system_image_guid(peer_dev);
+
+       return (fsystem_guid && psystem_guid && fsystem_guid == psystem_guid);
+}
+
 static u32 mlx5_gen_pci_id(const struct mlx5_core_dev *dev)
 {
        return (u32)((pci_domain_nr(dev->pdev->bus) << 16) |
@@ -556,7 +567,8 @@ static int next_phys_dev(struct device *dev, const void *data)
        if (mdev == curr)
                return 0;
 
-       if (mlx5_gen_pci_id(mdev) != mlx5_gen_pci_id(curr))
+       if (!mlx5_same_hw_devs(mdev, (struct mlx5_core_dev *)curr) &&
+           mlx5_gen_pci_id(mdev) != mlx5_gen_pci_id(curr))
                return 0;
 
        return 1;