ASoC: wm8350: don't use [delayed_]work_pending()
authorTejun Heo <tj@kernel.org>
Sat, 22 Dec 2012 01:57:03 +0000 (17:57 -0800)
committerMark Brown <broonie@opensource.wolfsonmicro.com>
Mon, 24 Dec 2012 16:10:22 +0000 (16:10 +0000)
There's no need to test whether a (delayed) work item in pending
before queueing, flushing or cancelling it.  Most uses are unnecessary
and quite a few of them are buggy.

Remove unnecessary pending tests from wm8350.  Only compile tested.

Signed-off-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
sound/soc/codecs/wm8350.c

index fb92fb4..ec0efc1 100644 (file)
@@ -283,18 +283,16 @@ static int pga_event(struct snd_soc_dapm_widget *w,
                out->ramp = WM8350_RAMP_UP;
                out->active = 1;
 
-               if (!delayed_work_pending(&codec->dapm.delayed_work))
-                       schedule_delayed_work(&codec->dapm.delayed_work,
-                                             msecs_to_jiffies(1));
+               schedule_delayed_work(&codec->dapm.delayed_work,
+                                     msecs_to_jiffies(1));
                break;
 
        case SND_SOC_DAPM_PRE_PMD:
                out->ramp = WM8350_RAMP_DOWN;
                out->active = 0;
 
-               if (!delayed_work_pending(&codec->dapm.delayed_work))
-                       schedule_delayed_work(&codec->dapm.delayed_work,
-                                             msecs_to_jiffies(1));
+               schedule_delayed_work(&codec->dapm.delayed_work,
+                                     msecs_to_jiffies(1));
                break;
        }