PM / devfreq: use put_device() instead of kfree()

Never directly free @dev after calling device_register() or
device_unregister(), even if device_register() returned an error.
Always use put_device() to give up the reference initialized.

Change-Id: I65b83e63daf44ff784753b2372890f07c6515a46
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>
[cw00.choi: Backported from mainline kernel]
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>

diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
index 39b557a..a77fc4e 100644 (file)
--- a/drivers/devfreq/devfreq.c
+++ b/drivers/devfreq/devfreq.c
@@ -642,7 +642,8 @@ struct devfreq *devfreq_add_device(struct device *dev,
        err = device_register(&devfreq->dev);
        if (err) {
                mutex_unlock(&devfreq->lock);
-               goto err_dev;
+               put_device(&devfreq->dev);
+               goto err_out;
        }
 
        devfreq->trans_table =  devm_kzalloc(&devfreq->dev,
@@ -688,6 +689,7 @@ err_init:
        mutex_unlock(&devfreq_list_lock);
 
        device_unregister(&devfreq->dev);
+       devfreq = NULL;
 err_dev:
        if (devfreq)
                kfree(devfreq);