staging: unisys: visorbus: move read_controlvm_event
authorDavid Kershner <david.kershner@unisys.com>
Mon, 19 Sep 2016 21:09:23 +0000 (17:09 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 20 Sep 2016 11:26:20 +0000 (13:26 +0200)
The function read_controlvm_event needs to be moved lower in the file
to avoid extraneous function prototypes.

Reported-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Reviewed-by: Tim Sell <Timothy.Sell@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/unisys/visorbus/visorchipset.c

index 168d42f..d8e5826 100644 (file)
@@ -1357,27 +1357,6 @@ chipset_notready(struct controlvm_message_header *msg_hdr)
                controlvm_respond(msg_hdr, rc);
 }
 
-/**
- * read_controlvm_event() - retreives the next message from the
- *                          CONTROLVM_QUEUE_EVENT queue in the controlvm
- *                          channel
- * @msg: pointer to the retrieved message
- *
- * Return: true if a valid message was retrieved or false otherwise
- */
-static bool
-read_controlvm_event(struct controlvm_message *msg)
-{
-       if (visorchannel_signalremove(controlvm_channel,
-                                     CONTROLVM_QUEUE_EVENT, msg)) {
-               /* got a message */
-               if (msg->hdr.flags.test_message == 1)
-                       return false;
-               return true;
-       }
-       return false;
-}
-
 /*
  * The general parahotplug flow works as follows. The visorchipset
  * driver receives a DEVICE_CHANGESTATE message from Command
@@ -2091,6 +2070,27 @@ handle_command(struct controlvm_message inmsg, u64 channel_addr)
        return true;
 }
 
+/**
+ * read_controlvm_event() - retreives the next message from the
+ *                          CONTROLVM_QUEUE_EVENT queue in the controlvm
+ *                          channel
+ * @msg: pointer to the retrieved message
+ *
+ * Return: true if a valid message was retrieved or false otherwise
+ */
+static bool
+read_controlvm_event(struct controlvm_message *msg)
+{
+       if (visorchannel_signalremove(controlvm_channel,
+                                     CONTROLVM_QUEUE_EVENT, msg)) {
+               /* got a message */
+               if (msg->hdr.flags.test_message == 1)
+                       return false;
+               return true;
+       }
+       return false;
+}
+
 static void
 controlvm_periodic_work(struct work_struct *work)
 {