Fix GN arm64 build, add msan support.
authorbrettw <brettw@chromium.org>
Tue, 1 Sep 2015 23:05:20 +0000 (16:05 -0700)
committerCommit bot <commit-bot@chromium.org>
Tue, 1 Sep 2015 23:05:28 +0000 (23:05 +0000)
The arm64 build is missing a few recently-added files.

Compiling with msan requires that v8 be compiled in arm64 mode. Hook this up.

Review URL: https://codereview.chromium.org/1316233005

Cr-Commit-Position: refs/heads/master@{#30528}

BUILD.gn

index 2b8f46a..434bb65 100644 (file)
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -22,10 +22,18 @@ v8_interpreted_regexp = false
 v8_object_print = false
 v8_postmortem_support = false
 v8_use_snapshot = true
-v8_target_arch = target_cpu
 v8_random_seed = "314159265"
 v8_toolset_for_d8 = "host"
 
+if (is_msan) {
+  # Running the V8-generated code on an ARM simulator is a powerful hack that
+  # allows the tool to see the memory accesses from JITted code. Without this
+  # flag, JS code causes false positive reports from MSan.
+  v8_target_arch = "arm64"
+} else {
+  v8_target_arch = target_cpu
+}
+
 # The snapshot needs to be compiled for the host, but compiled with
 # a toolchain that matches the bit-width of the target.
 #
@@ -1382,6 +1390,9 @@ source_set("v8_base") {
       "src/arm64/decoder-arm64.cc",
       "src/arm64/decoder-arm64.h",
       "src/arm64/decoder-arm64-inl.h",
+      "src/arm64/delayed-masm-arm64.cc",
+      "src/arm64/delayed-masm-arm64.h",
+      "src/arm64/delayed-masm-arm64-inl.h",
       "src/arm64/deoptimizer-arm64.cc",
       "src/arm64/disasm-arm64.cc",
       "src/arm64/disasm-arm64.h",