ristsink: Fix error handling on bad DNS
authorNicolas Dufresne <nicolas.dufresne@collabora.com>
Fri, 10 Jul 2020 22:03:20 +0000 (18:03 -0400)
committerGStreamer Merge Bot <gitlab-merge-bot@gstreamer-foundation.org>
Tue, 14 Jul 2020 20:48:04 +0000 (20:48 +0000)
This will properly print the DNS being attempted to resolved and avoid
trying to unref a NULL pointer.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1433>

gst/rist/gstristsink.c

index 464b071..6622257 100644 (file)
@@ -700,10 +700,8 @@ gst_rist_sink_setup_rtcp_socket (GstRistSink * sink, RistSenderBond * bond)
 
 dns_resolve_failed:
   GST_ELEMENT_ERROR (sink, RESOURCE, NOT_FOUND,
-      ("Could not resolve hostname '%s'", GST_STR_NULL (remote_addr)),
+      ("Could not resolve hostname '%s'", GST_STR_NULL (bond->address)),
       ("DNS resolver reported: %s", error->message));
-  g_free (remote_addr);
-  g_object_unref (iaddr);
   g_error_free (error);
   return GST_STATE_CHANGE_FAILURE;
 }