HID: fix an error code in hid_check_device_match()
authorDan Carpenter <dan.carpenter@linaro.org>
Tue, 6 Jun 2023 08:20:54 +0000 (11:20 +0300)
committerJiri Kosina <jkosina@suse.cz>
Thu, 8 Jun 2023 15:00:09 +0000 (17:00 +0200)
The hid_check_device_match() returns true if we find a match and false
if we don't.  But here it returns -ENODEV which becomes true instead
of false.

Fixes: 207733f92661 ("HID: split apart hid_device_probe to make logic more apparent")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Reviewed-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
drivers/hid/hid-core.c

index 4b7062d..8992e3c 100644 (file)
@@ -2593,7 +2593,7 @@ static bool hid_check_device_match(struct hid_device *hdev,
 {
        *id = hid_match_device(hdev, hdrv);
        if (!*id)
-               return -ENODEV;
+               return false;
 
        if (hdrv->match)
                return hdrv->match(hdev, hid_ignore_special_drivers);