ASoC: SOF: add a pointer to download repo in case FW request fails

The SOF firmware and topology files are not distributed via
linux-firmware. To help debugging cases where correct firmware is
not installed, print a pointer to the official upstream repository
for Sound Open Firmware releases.

BugLink: https://github.com/thesofproject/sof/issues/3665
Reported-by: Bruce Perens <bruce@perens.com>
Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Reviewed-by: Marc Herbert <marc.herbert@intel.com>
Reviewed-by: Liam Girdwood <liam.r.girdwood@intel.com>
Link: https://lore.kernel.org/r/20210127122358.1014458-1-kai.vehmanen@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>

diff --git a/sound/soc/sof/loader.c b/sound/soc/sof/loader.c
index 08a17ab..eabeaf7 100644 (file)
--- a/sound/soc/sof/loader.c
+++ b/sound/soc/sof/loader.c
@@ -731,6 +731,8 @@ int snd_sof_load_firmware_raw(struct snd_sof_dev *sdev)
        if (ret < 0) {
                dev_err(sdev->dev, "error: request firmware %s failed err: %d\n",
                        fw_filename, ret);
+               dev_err(sdev->dev,
+                       "you may need to download the firmware from https://github.com/thesofproject/sof-bin/\n");
                goto err;
        } else {
                dev_dbg(sdev->dev, "request_firmware %s successful\n",

diff --git a/sound/soc/sof/topology.c b/sound/soc/sof/topology.c
index b6b32a7..59f89f3 100644 (file)
--- a/sound/soc/sof/topology.c
+++ b/sound/soc/sof/topology.c
@@ -3740,6 +3740,8 @@ int snd_sof_load_topology(struct snd_soc_component *scomp, const char *file)
        if (ret < 0) {
                dev_err(scomp->dev, "error: tplg request firmware %s failed err: %d\n",
                        file, ret);
+               dev_err(scomp->dev,
+                       "you may need to download the firmware from https://github.com/thesofproject/sof-bin/\n");
                return ret;
        }