platform/chrome: typec: Fix ret value check error
authorPrashant Malani <pmalani@chromium.org>
Wed, 22 Apr 2020 00:41:51 +0000 (17:41 -0700)
committerBenson Leung <bleung@chromium.org>
Wed, 22 Apr 2020 00:51:04 +0000 (17:51 -0700)
cros_typec_add_partner() returns 0 on success, so check for "ret"
instead of "!ret" as an error.

Signed-off-by: Prashant Malani <pmalani@chromium.org>
Fixes: 9d33ea331032 ("platform/chrome: cros_ec_typec: Register port partner")
Signed-off-by: Benson Leung <bleung@chromium.org>
drivers/platform/chrome/cros_ec_typec.c

index eda57db..66b8d21 100644 (file)
@@ -263,7 +263,7 @@ static void cros_typec_set_port_params_v1(struct cros_typec_data *typec,
 
                pd_en = resp->enabled & PD_CTRL_RESP_ENABLED_PD_CAPABLE;
                ret = cros_typec_add_partner(typec, port_num, pd_en);
-               if (!ret)
+               if (ret)
                        dev_warn(typec->dev,
                                 "Failed to register partner on port: %d\n",
                                 port_num);