re PR rtl-optimization/89234 (ICE in get_eh_region_and_lp_from_rtx at gcc/except...

	PR rtl-optimization/89234
	* except.c (copy_reg_eh_region_note_forward): Return if note_or_insn
	is a NOTE, CODE_LABEL etc. - rtx_insn * other than INSN_P.
	(copy_reg_eh_region_note_backward): Likewise.

	* g++.dg/ubsan/pr89234.C: New test.

From-SVN: r268669

diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index 4e78ab6..14c6183 100644 (file)
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,3 +1,10 @@
+2019-02-08  Jakub Jelinek  <jakub@redhat.com>
+
+       PR rtl-optimization/89234
+       * except.c (copy_reg_eh_region_note_forward): Return if note_or_insn
+       is a NOTE, CODE_LABEL etc. - rtx_insn * other than INSN_P.
+       (copy_reg_eh_region_note_backward): Likewise.
+
 2019-02-08  Richard Biener  <rguenther@suse.de>
 
        PR middle-end/89223

diff --git a/gcc/except.c b/gcc/except.c
index 10fef2f..29437f3 100644 (file)
--- a/gcc/except.c
+++ b/gcc/except.c
@@ -1756,6 +1756,8 @@ copy_reg_eh_region_note_forward (rtx note_or_insn, rtx_insn *first, rtx last)
       if (note == NULL)
        return;
     }
+  else if (is_a <rtx_insn *> (note_or_insn))
+    return;
   note = XEXP (note, 0);
 
   for (insn = first; insn != last ; insn = NEXT_INSN (insn))
@@ -1778,6 +1780,8 @@ copy_reg_eh_region_note_backward (rtx note_or_insn, rtx_insn *last, rtx first)
       if (note == NULL)
        return;
     }
+  else if (is_a <rtx_insn *> (note_or_insn))
+    return;
   note = XEXP (note, 0);
 
   for (insn = last; insn != first; insn = PREV_INSN (insn))

diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index 9f4296b..fd3fbf1 100644 (file)
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2019-02-08  Jakub Jelinek  <jakub@redhat.com>
+
+       PR rtl-optimization/89234
+       * g++.dg/ubsan/pr89234.C: New test.
+
 2019-02-08  Richard Biener  <rguenther@suse.de>
 
        PR middle-end/89223

diff --git a/gcc/testsuite/g++.dg/ubsan/pr89234.C b/gcc/testsuite/g++.dg/ubsan/pr89234.C
new file mode 100644 (file)
index 0000000..af1526c
--- /dev/null
+++ b/gcc/testsuite/g++.dg/ubsan/pr89234.C
@@ -0,0 +1,11 @@
+// PR rtl-optimization/89234
+// { dg-do compile { target dfp } }
+// { dg-options "-O2 -fnon-call-exceptions -fsanitize=null" }
+
+typedef float __attribute__((mode (SD))) _Decimal32;
+
+void
+foo (_Decimal32 *b, _Decimal32 c)
+{
+  *b = c + 1.5;
+}