pinctrl: sx150x: Unregister the pinctrl on release
authorPeter Rosin <peda@axentia.se>
Wed, 17 Jan 2018 13:34:21 +0000 (14:34 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 16 Feb 2018 19:23:08 +0000 (20:23 +0100)
commit 0657cb50b5a75abd92956028727dc255d690a4a6 upstream.

There is no matching call to pinctrl_unregister, so switch to the
managed devm_pinctrl_register to clean up properly when done.

Fixes: 9e80f9064e73 ("pinctrl: Add SX150X GPIO Extender Pinctrl Driver")
Signed-off-by: Peter Rosin <peda@axentia.se>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/pinctrl/pinctrl-sx150x.c

index 7450f51..7b0d597 100644 (file)
@@ -1225,7 +1225,7 @@ static int sx150x_probe(struct i2c_client *client,
        pctl->pinctrl_desc.npins = pctl->data->npins;
        pctl->pinctrl_desc.owner = THIS_MODULE;
 
-       pctl->pctldev = pinctrl_register(&pctl->pinctrl_desc, dev, pctl);
+       pctl->pctldev = devm_pinctrl_register(dev, &pctl->pinctrl_desc, pctl);
        if (IS_ERR(pctl->pctldev)) {
                dev_err(dev, "Failed to register pinctrl device\n");
                return PTR_ERR(pctl->pctldev);