[X86][NFC] Correct the instruction names for PUSH16i, PUSH32i
authorShengchen Kan <shengchen.kan@intel.com>
Sat, 20 May 2023 03:30:28 +0000 (11:30 +0800)
committerShengchen Kan <shengchen.kan@intel.com>
Sat, 20 May 2023 09:33:42 +0000 (17:33 +0800)
Reviewed By: maksfb

Differential Revision: https://reviews.llvm.org/D151012

bolt/lib/Target/X86/X86MCPlusBuilder.cpp
llvm/lib/Target/X86/MCTargetDesc/X86InstrRelaxTables.cpp
llvm/lib/Target/X86/X86CallFrameOptimization.cpp
llvm/lib/Target/X86/X86DynAllocaExpander.cpp
llvm/lib/Target/X86/X86FrameLowering.cpp
llvm/lib/Target/X86/X86InstrInfo.cpp
llvm/lib/Target/X86/X86InstrMisc.td
llvm/lib/Target/X86/X86ScheduleAtom.td

index 6c9b5e1..a1a86e9 100644 (file)
@@ -270,7 +270,7 @@ public:
     case X86::PUSHFS16:
     case X86::PUSHGS16:
     case X86::PUSHSS16:
-    case X86::PUSHi16:
+    case X86::PUSH16i:
       return 2;
     case X86::PUSH32i8:
     case X86::PUSH32r:
@@ -284,7 +284,7 @@ public:
     case X86::PUSHFS32:
     case X86::PUSHGS32:
     case X86::PUSHSS32:
-    case X86::PUSHi32:
+    case X86::PUSH32i:
       return 4;
     case X86::PUSH64i32:
     case X86::PUSH64i8:
@@ -2548,8 +2548,8 @@ public:
     default: {
       switch (getPushSize(Inst)) {
 
-      case 2: I = {2, false, {{CHECK8, X86::PUSH16i8}, {NOCHECK, X86::PUSHi16}}}; break;
-      case 4: I = {4, false, {{CHECK8, X86::PUSH32i8}, {NOCHECK, X86::PUSHi32}}}; break;
+      case 2: I = {2, false, {{CHECK8, X86::PUSH16i8}, {NOCHECK, X86::PUSH16i}}}; break;
+      case 4: I = {4, false, {{CHECK8, X86::PUSH32i8}, {NOCHECK, X86::PUSH32i}}}; break;
       case 8: I = {8, false, {{CHECK8, X86::PUSH64i8},
                               {CHECK32, X86::PUSH64i32},
                               {NOCHECK, Inst.getOpcode()}}}; break;
index 640efd4..afeaaec 100644 (file)
@@ -65,8 +65,8 @@ static const X86InstrRelaxTableEntry InstrRelaxTable[] = {
   { X86::OR64mi8,    X86::OR64mi32    },
   { X86::OR64ri8,    X86::OR64ri32    },
   // PUSH
-  { X86::PUSH16i8,   X86::PUSHi16     },
-  { X86::PUSH32i8,   X86::PUSHi32     },
+  { X86::PUSH16i8,   X86::PUSH16i     },
+  { X86::PUSH32i8,   X86::PUSH32i     },
   { X86::PUSH64i8,   X86::PUSH64i32   },
   // SBB
   { X86::SBB16mi8,   X86::SBB16mi     },
index 1367d2e..2bebd01 100644 (file)
@@ -520,7 +520,7 @@ void X86CallFrameOptimization::adjustCallSequence(MachineFunction &MF,
     case X86::OR64mi32:
     case X86::MOV32mi:
     case X86::MOV64mi32:
-      PushOpcode = Is64Bit ? X86::PUSH64i32 : X86::PUSHi32;
+      PushOpcode = Is64Bit ? X86::PUSH64i32 : X86::PUSH32i;
       // If the operand is a small (8-bit) immediate, we can use a
       // PUSH instruction with a shorter encoding.
       // Note that isImm() may fail even though this is a MOVmi, because
index bd2a663..978f2db 100644 (file)
@@ -114,7 +114,7 @@ static bool isPushPop(const MachineInstr &MI) {
   case X86::PUSH32r:
   case X86::PUSH32rmm:
   case X86::PUSH32rmr:
-  case X86::PUSHi32:
+  case X86::PUSH32i:
   case X86::PUSH64i8:
   case X86::PUSH64r:
   case X86::PUSH64rmm:
index fed7131..0619029 100644 (file)
@@ -3251,9 +3251,9 @@ void X86FrameLowering::adjustForSegmentedStacks(
             Reg11)
         .addImm(X86FI->getArgumentStackSize());
   } else {
-    BuildMI(allocMBB, DL, TII.get(X86::PUSHi32))
+    BuildMI(allocMBB, DL, TII.get(X86::PUSH32i))
       .addImm(X86FI->getArgumentStackSize());
-    BuildMI(allocMBB, DL, TII.get(X86::PUSHi32))
+    BuildMI(allocMBB, DL, TII.get(X86::PUSH32i))
       .addImm(StackSize);
   }
 
index 708943f..6c1bc59 100644 (file)
@@ -436,7 +436,7 @@ int X86InstrInfo::getSPAdjust(const MachineInstr &MI) const {
   case X86::PUSH32r:
   case X86::PUSH32rmm:
   case X86::PUSH32rmr:
-  case X86::PUSHi32:
+  case X86::PUSH32i:
     return 4;
   case X86::PUSH64i8:
   case X86::PUSH64r:
index f3ca5bc..88e7a38 100644 (file)
@@ -92,13 +92,13 @@ def PUSH32rmr: I<0xFF, MRM6r, (outs), (ins GR32:$reg), "push{l}\t$reg",[]>,
 
 def PUSH16i8 : Ii8<0x6a, RawFrm, (outs), (ins i16i8imm:$imm),
                    "push{w}\t$imm", []>, OpSize16;
-def PUSHi16  : Ii16<0x68, RawFrm, (outs), (ins i16imm:$imm),
+def PUSH16i  : Ii16<0x68, RawFrm, (outs), (ins i16imm:$imm),
                    "push{w}\t$imm", []>, OpSize16;
 
 def PUSH32i8 : Ii8<0x6a, RawFrm, (outs), (ins i32i8imm:$imm),
                    "push{l}\t$imm", []>, OpSize32,
                    Requires<[Not64BitMode]>;
-def PUSHi32  : Ii32<0x68, RawFrm, (outs), (ins i32imm:$imm),
+def PUSH32i  : Ii32<0x68, RawFrm, (outs), (ins i32imm:$imm),
                    "push{l}\t$imm", []>, OpSize32,
                    Requires<[Not64BitMode]>;
 } // mayStore, SchedRW
index 09a0918..b733616 100644 (file)
@@ -537,7 +537,7 @@ def AtomWrite0_1_1 : SchedWriteRes<[AtomPort0, AtomPort1]> {
 def : InstRW<[AtomWrite0_1_1], (instrs POP32r, POP64r,
                                        POP16rmr, POP32rmr, POP64rmr,
                                        PUSH16r, PUSH32r, PUSH64r,
-                                       PUSHi16, PUSHi32,
+                                       PUSH16i, PUSH32i,
                                        PUSH16rmr, PUSH32rmr, PUSH64rmr,
                                        PUSH16i8, PUSH32i8, PUSH64i8, PUSH64i32,
                                        XCH_F)>;