net: ppp: Remove unnecessary (void*) conversions
authorWu Yunchuan <yunchuan@nfschina.com>
Mon, 17 Jul 2023 03:11:15 +0000 (11:11 +0800)
committerJakub Kicinski <kuba@kernel.org>
Wed, 19 Jul 2023 02:00:47 +0000 (19:00 -0700)
No need cast (void*) to (struct sock *).

Signed-off-by: Wu Yunchuan <yunchuan@nfschina.com>
Reviewed-by: Guillaume Nault <gnault@redhat.com>
Link: https://lore.kernel.org/r/20230717031115.54432-1-yunchuan@nfschina.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ppp/pppoe.c
drivers/net/ppp/pptp.c

index 3b79c60..ba8b6bd 100644 (file)
@@ -968,7 +968,7 @@ abort:
  ***********************************************************************/
 static int pppoe_xmit(struct ppp_channel *chan, struct sk_buff *skb)
 {
-       struct sock *sk = (struct sock *)chan->private;
+       struct sock *sk = chan->private;
        return __pppoe_xmit(sk, skb);
 }
 
@@ -976,7 +976,7 @@ static int pppoe_fill_forward_path(struct net_device_path_ctx *ctx,
                                   struct net_device_path *path,
                                   const struct ppp_channel *chan)
 {
-       struct sock *sk = (struct sock *)chan->private;
+       struct sock *sk = chan->private;
        struct pppox_sock *po = pppox_sk(sk);
        struct net_device *dev = po->pppoe_dev;
 
index 57d38b2..6833ef0 100644 (file)
@@ -148,7 +148,7 @@ static struct rtable *pptp_route_output(const struct pppox_sock *po,
 
 static int pptp_xmit(struct ppp_channel *chan, struct sk_buff *skb)
 {
-       struct sock *sk = (struct sock *) chan->private;
+       struct sock *sk = chan->private;
        struct pppox_sock *po = pppox_sk(sk);
        struct net *net = sock_net(sk);
        struct pptp_opt *opt = &po->proto.pptp;
@@ -575,7 +575,7 @@ out:
 static int pptp_ppp_ioctl(struct ppp_channel *chan, unsigned int cmd,
        unsigned long arg)
 {
-       struct sock *sk = (struct sock *) chan->private;
+       struct sock *sk = chan->private;
        struct pppox_sock *po = pppox_sk(sk);
        struct pptp_opt *opt = &po->proto.pptp;
        void __user *argp = (void __user *)arg;