drm/amd/display: Ensure all debug bits are passed to fw
authorWyatt Wood <wyatt.wood@amd.com>
Fri, 25 Sep 2020 14:54:49 +0000 (10:54 -0400)
committerAlex Deucher <alexander.deucher@amd.com>
Tue, 29 Sep 2020 20:08:37 +0000 (16:08 -0400)
[Why]
Some debug bits are not being copied from driver to fw.

[How]
Copy debug bits properly.

Signed-off-by: Wyatt Wood <wyatt.wood@amd.com>
Reviewed-by: Anthony Koo <Anthony.Koo@amd.com>
Acked-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/dc/dce/dmub_psr.c

index bf24f10..67af67e 100644 (file)
@@ -256,10 +256,11 @@ static bool dmub_psr_copy_settings(struct dmub_psr *dmub,
        copy_settings_data->smu_optimizations_en                = psr_context->allow_smu_optimizations;
        copy_settings_data->frame_delay                         = psr_context->frame_delay;
        copy_settings_data->frame_cap_ind                       = psr_context->psrFrameCaptureIndicationReq;
+       copy_settings_data->init_sdp_deadline                   = psr_context->sdpTransmitLineNumDeadline;
+       copy_settings_data->debug.u32All = 0;
        copy_settings_data->debug.bitfields.visual_confirm      = dc->dc->debug.visual_confirm == VISUAL_CONFIRM_PSR ?
                                                                        true : false;
-       copy_settings_data->debug.bitfields.use_hw_lock_mgr     = 1;
-       copy_settings_data->init_sdp_deadline                   = psr_context->sdpTransmitLineNumDeadline;
+       copy_settings_data->debug.bitfields.use_hw_lock_mgr             = 1;
 
        dc_dmub_srv_cmd_queue(dc->dmub_srv, &cmd);
        dc_dmub_srv_cmd_execute(dc->dmub_srv);