Disable signing and publishing on perf builds (dotnet/coreclr#26390)
authorMichelle McDaniel <adiaaida@gmail.com>
Wed, 28 Aug 2019 22:08:41 +0000 (15:08 -0700)
committerGitHub <noreply@github.com>
Wed, 28 Aug 2019 22:08:41 +0000 (15:08 -0700)
* Disable signing and publishing on perf builds

* Mark default to false

* Change to signBinaries and publishToBlobFeed

Commit migrated from https://github.com/dotnet/coreclr/commit/8feac49899d6b86049786f1482576a39bbc522d6

eng/build-job.yml
eng/pipelines/coreclr/internal.yml

index 2a952d2..0e18ad8 100644 (file)
@@ -6,6 +6,8 @@ parameters:
   container: ''
   crossrootfsDir: ''
   timeoutInMinutes: ''
+  signBinaries: false
+  publishToBlobFeed: false
 
 ### Product build
 jobs:
@@ -125,7 +127,7 @@ jobs:
         displayName: Build product
 
     # Sign on Windows
-    - ${{ if and(ne(variables['System.TeamProject'], 'public'), ne(variables['Build.Reason'], 'PullRequest'), eq(parameters.osGroup, 'Windows_NT')) }}:
+    - ${{ if and(eq(parameters.osGroup, 'Windows_NT'), eq(parameters.signBinaries, 'true')) }}:
       - powershell: eng\common\build.ps1 -ci -sign -restore -configuration:$(buildConfig) -warnaserror:0 /p:ArcadeBuild=true /p:OfficialBuild=true /p:BuildOS=$(osGroup) /p:BuildArch=$(archType) /p:BuildType=$(_BuildConfig) /p:DotNetSignType=$env:_SignType -projects $(Build.SourcesDirectory)\eng\empty.csproj
         displayName: Sign Binaries
 
@@ -162,7 +164,7 @@ jobs:
         displayName: Build packages
 
     # Publish official build
-    - ${{ if and(ne(variables['System.TeamProject'], 'public'), ne(variables['Build.Reason'], 'PullRequest')) }}:
+    - ${{ if eq(parameters.publishToBlobFeed, 'true') }}:
       - ${{ if ne(parameters.osGroup, 'Windows_NT') }}:
         - script: ./eng/common/build.sh --ci --restore --publish --configuration $(_BuildConfig) /p:DotNetPublishUsingPipelines=true /p:DotNetPublishToBlobFeed=true /p:DotNetPublishBlobFeedUrl=$(dotnetfeedUrl) /p:DotNetPublishBlobFeedKey=$(dotnetfeedPAT) /p:__BuildType=$(_BuildConfig) /p:__BuildArch=$(archType) /p:__BuildOS=$(osGroup) /p:OSIdentifier=$(osIdentifier) /bl:"$(Build.SourcesDirectory)/bin/Logs/publish-pkgs.binlog" --projects $(Build.SourcesDirectory)/eng/empty.csproj
           displayName: Publish packages to blob feed
index 4c663ca..fce432f 100644 (file)
@@ -42,6 +42,8 @@ stages:
           # due to waiting for an exclusive lock on the feed.
           # See https://github.com/dotnet/arcade/blob/master/Documentation/CorePackages/AsyncPublishing.md
           timeoutInMinutes: 120
+          signBinaries: true
+          publishToBlobFeed: true
 
     #
     # Publish build information to Build Assets Registry