projects
/
platform
/
kernel
/
linux-rpi.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
8f2b025
)
ASoC: amd: acp: Fix signedness bug in renoir_audio_probe()
author
Dan Carpenter
<dan.carpenter@oracle.com>
Fri, 4 Mar 2022 13:14:49 +0000
(16:14 +0300)
committer
Mark Brown
<broonie@kernel.org>
Mon, 7 Mar 2022 13:14:47 +0000
(13:14 +0000)
The "adata->i2s_irq" is unsigned so this error handling will not
work.
Fixes:
3304a242f45a
("ASoC: amd: Use platform_get_irq_byname() to get the interrupt")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link:
https://lore.kernel.org/r/20220304131449.GC28739@kili
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/amd/acp/acp-renoir.c
patch
|
blob
|
history
diff --git
a/sound/soc/amd/acp/acp-renoir.c
b/sound/soc/amd/acp/acp-renoir.c
index
738cf2e
..
75c9229
100644
(file)
--- a/
sound/soc/amd/acp/acp-renoir.c
+++ b/
sound/soc/amd/acp/acp-renoir.c
@@
-282,9
+282,10
@@
static int renoir_audio_probe(struct platform_device *pdev)
if (!adata->acp_base)
return -ENOMEM;
- adata->i2s_irq = platform_get_irq_byname(pdev, "acp_dai_irq");
- if (adata->i2s_irq < 0)
- return -ENODEV;
+ ret = platform_get_irq_byname(pdev, "acp_dai_irq");
+ if (ret < 0)
+ return ret;
+ adata->i2s_irq = ret;
adata->dev = dev;
adata->dai_driver = acp_renoir_dai;