fanotify: factor out helper fanotify_mark_update_flags()

Handle FAN_MARK_IGNORED_SURV_MODIFY flag change in a helper that
is called after updating the mark mask.

Replace the added and removed return values and help variables with
bool recalc return values and help variable, which makes the code a
bit easier to follow.

Rename flags argument to fan_flags to emphasize the difference from
mark->flags.

Link: https://lore.kernel.org/r/20220422120327.3459282-14-amir73il@gmail.com
Signed-off-by: Amir Goldstein <amir73il@gmail.com>
Signed-off-by: Jan Kara <jack@suse.cz>

diff --git a/fs/notify/fanotify/fanotify_user.c b/fs/notify/fanotify/fanotify_user.c
index 3649c99..4005ee8 100644 (file)
--- a/fs/notify/fanotify/fanotify_user.c
+++ b/fs/notify/fanotify/fanotify_user.c
@@ -1081,42 +1081,45 @@ static int fanotify_remove_inode_mark(struct fsnotify_group *group,
                                    flags, umask);
 }
 
-static void fanotify_mark_add_ignored_mask(struct fsnotify_mark *fsn_mark,
-                                          __u32 mask, unsigned int flags,
-                                          __u32 *removed)
+static bool fanotify_mark_update_flags(struct fsnotify_mark *fsn_mark,
+                                      unsigned int fan_flags)
 {
-       fsn_mark->ignored_mask |= mask;
+       bool recalc = false;
 
        /*
         * Setting FAN_MARK_IGNORED_SURV_MODIFY for the first time may lead to
         * the removal of the FS_MODIFY bit in calculated mask if it was set
         * because of an ignored mask that is now going to survive FS_MODIFY.
         */
-       if ((flags & FAN_MARK_IGNORED_SURV_MODIFY) &&
+       if ((fan_flags & FAN_MARK_IGNORED_MASK) &&
+           (fan_flags & FAN_MARK_IGNORED_SURV_MODIFY) &&
            !(fsn_mark->flags & FSNOTIFY_MARK_FLAG_IGNORED_SURV_MODIFY)) {
                fsn_mark->flags |= FSNOTIFY_MARK_FLAG_IGNORED_SURV_MODIFY;
                if (!(fsn_mark->mask & FS_MODIFY))
-                       *removed = FS_MODIFY;
+                       recalc = true;
        }
+
+       return recalc;
 }
 
-static __u32 fanotify_mark_add_to_mask(struct fsnotify_mark *fsn_mark,
-                                      __u32 mask, unsigned int flags,
-                                      __u32 *removed)
+static bool fanotify_mark_add_to_mask(struct fsnotify_mark *fsn_mark,
+                                     __u32 mask, unsigned int fan_flags)
 {
-       __u32 oldmask, newmask;
+       bool recalc;
 
        spin_lock(&fsn_mark->lock);
-       oldmask = fsnotify_calc_mask(fsn_mark);
-       if (!(flags & FAN_MARK_IGNORED_MASK)) {
+       if (!(fan_flags & FAN_MARK_IGNORED_MASK))
                fsn_mark->mask |= mask;
-       } else {
-               fanotify_mark_add_ignored_mask(fsn_mark, mask, flags, removed);
-       }
-       newmask = fsnotify_calc_mask(fsn_mark);
+       else
+               fsn_mark->ignored_mask |= mask;
+
+       recalc = fsnotify_calc_mask(fsn_mark) &
+               ~fsnotify_conn_mask(fsn_mark->connector);
+
+       recalc |= fanotify_mark_update_flags(fsn_mark, fan_flags);
        spin_unlock(&fsn_mark->lock);
 
-       return newmask & ~oldmask;
+       return recalc;
 }
 
 static struct fsnotify_mark *fanotify_add_new_mark(struct fsnotify_group *group,
@@ -1170,11 +1173,11 @@ static int fanotify_group_init_error_pool(struct fsnotify_group *group)
 
 static int fanotify_add_mark(struct fsnotify_group *group,
                             fsnotify_connp_t *connp, unsigned int obj_type,
-                            __u32 mask, unsigned int flags,
+                            __u32 mask, unsigned int fan_flags,
                             __kernel_fsid_t *fsid)
 {
        struct fsnotify_mark *fsn_mark;
-       __u32 added, removed = 0;
+       bool recalc;
        int ret = 0;
 
        mutex_lock(&group->mark_mutex);
@@ -1191,14 +1194,14 @@ static int fanotify_add_mark(struct fsnotify_group *group,
         * Error events are pre-allocated per group, only if strictly
         * needed (i.e. FAN_FS_ERROR was requested).
         */
-       if (!(flags & FAN_MARK_IGNORED_MASK) && (mask & FAN_FS_ERROR)) {
+       if (!(fan_flags & FAN_MARK_IGNORED_MASK) && (mask & FAN_FS_ERROR)) {
                ret = fanotify_group_init_error_pool(group);
                if (ret)
                        goto out;
        }
 
-       added = fanotify_mark_add_to_mask(fsn_mark, mask, flags, &removed);
-       if (removed || (added & ~fsnotify_conn_mask(fsn_mark->connector)))
+       recalc = fanotify_mark_add_to_mask(fsn_mark, mask, fan_flags);
+       if (recalc)
                fsnotify_recalc_mask(fsn_mark->connector);
 
 out: