Add static keyword into global variables

- Issue:
Some global variables can be accessed by other files, because those are
not hided from others. It can allow malicious access.

- Solution:
This patch adds static keyword into global variables that are used only
in the file.

Change-Id: I85a0563027fc94dcd9d31eb508b37f237678b0e0
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>

diff --git a/client/tts_ipc.c b/client/tts_ipc.c
index 183c163257a50ecaac7c579a7ef1c6a3725973f2..15484f0a4b5d778bd9f96997bd0421359c9fcd8b 100644 (file)
--- a/client/tts_ipc.c
+++ b/client/tts_ipc.c
@@ -36,13 +36,13 @@ typedef enum {
 } tts_ipc_vtable_e;
 
 
-int(*ttsc_dbus_vtable[])() = { &tts_dbus_open_connection, &tts_dbus_close_connection, &tts_dbus_stop_listening,
+static int(*ttsc_dbus_vtable[])() = { &tts_dbus_open_connection, &tts_dbus_close_connection, &tts_dbus_stop_listening,
                                                &tts_dbus_request_hello, &tts_dbus_request_hello_sync, &tts_dbus_request_initialize,
                                                &tts_dbus_request_finalize, &tts_dbus_request_add_text, &tts_dbus_request_play, &tts_dbus_request_stop,
                                                &tts_dbus_request_pause, &tts_dbus_request_set_private_data, &tts_dbus_request_get_private_data,
                                                &tts_dbus_request_play_pcm, &tts_dbus_request_stop_pcm, &tts_dbus_request_add_pcm, &tts_dbus_request_set_mode };
 
-int(*ttsc_tidl_vtable[])() = { &tts_tidl_open_connection, &tts_tidl_close_connection, &tts_tidl_stop_listening,
+static int(*ttsc_tidl_vtable[])() = { &tts_tidl_open_connection, &tts_tidl_close_connection, &tts_tidl_stop_listening,
                                                &tts_tidl_request_hello, &tts_tidl_request_hello_sync, &tts_tidl_request_initialize,
                                                &tts_tidl_request_finalize, &tts_tidl_request_add_text, &tts_tidl_request_play, &tts_tidl_request_stop,
                                                &tts_tidl_request_pause, &tts_tidl_request_set_private_data, &tts_tidl_request_get_private_data,

diff --git a/engine-parser/src/tts-engine-parser.c b/engine-parser/src/tts-engine-parser.c
index 77ebe26979ed49474b3e452e4c922aa888f1f9e0..9328a870dd178110b857c9c671ad52d9106fa078 100644 (file)
--- a/engine-parser/src/tts-engine-parser.c
+++ b/engine-parser/src/tts-engine-parser.c
@@ -96,17 +96,17 @@ typedef struct {
 } voice_info_list_s;
 
 static xmlDocPtr g_doc;
-GumUser *g_guser = NULL;
-uid_t g_uid = 301;     // app_fw
-gid_t g_gid = 301;     // app_fw
-gchar *g_user_type = NULL;
+static GumUser *g_guser = NULL;
+static uid_t g_uid = 301;      // app_fw
+static gid_t g_gid = 301;      // app_fw
+static gchar *g_user_type = NULL;
 
-char *g_dir_config_base = NULL;
-char *g_dir_home = NULL;
-char *g_dir_engine_base = NULL;
-char *g_dir_engine_info = NULL;
+static char *g_dir_config_base = NULL;
+static char *g_dir_home = NULL;
+static char *g_dir_engine_base = NULL;
+static char *g_dir_engine_info = NULL;
 
-GSList *g_voice_info_list = NULL;
+static GSList *g_voice_info_list = NULL;
 
 static int __create_engine_info_xml(const char *pkgid)
 {

diff --git a/server/ttsd_ipc.c b/server/ttsd_ipc.c
index 2b04bdb84d6fcfc92bb0b1eb7079309edf04abf9..bef45337d4e4356b65572610f03a8c9e23979a76 100644 (file)
--- a/server/ttsd_ipc.c
+++ b/server/ttsd_ipc.c
@@ -17,9 +17,9 @@
 #include "ttsd_data.h"
 
 
-int(*ttsd_dbus_vtable[])() = {&ttsd_dbus_open_connection, &ttsd_dbus_close_connection, &ttsdc_dbus_send_utt_start_message,
+static int(*ttsd_dbus_vtable[])() = {&ttsd_dbus_open_connection, &ttsd_dbus_close_connection, &ttsdc_dbus_send_utt_start_message,
                                        &ttsdc_dbus_send_utt_finish_message, &ttsdc_dbus_send_set_state_message, &ttsdc_dbus_send_error_message};
-int(*ttsd_tidl_vtable[])() = {&ttsd_tidl_open_connection, &ttsd_tidl_close_connection, &ttsdc_tidl_send_utt_start_message,
+static int(*ttsd_tidl_vtable[])() = {&ttsd_tidl_open_connection, &ttsd_tidl_close_connection, &ttsdc_tidl_send_utt_start_message,
                                        &ttsdc_tidl_send_utt_finish_message, &ttsdc_tidl_send_set_state_message, &ttsdc_tidl_send_error_message};
 
 int ttsd_ipc_open_connection()

diff --git a/server/ttsd_tidl.c b/server/ttsd_tidl.c
index 281134e22f60b9a607daa575e427c92911d0af38..f5cdca824704d2c8ab505efbfcb0d53f69bebd75 100644 (file)
--- a/server/ttsd_tidl.c
+++ b/server/ttsd_tidl.c
@@ -28,7 +28,7 @@ typedef struct {
 
 static GList* g_tidl_proxy_infos = NULL;
 
-rpc_port_stub_tts_callback_s g_callback;
+static rpc_port_stub_tts_callback_s g_callback;
 
 static pthread_mutex_t g_tidl_proxy_infos_mutex = PTHREAD_MUTEX_INITIALIZER;