pinctrl: sh-pfc: checker: Add bias register checks
authorGeert Uytterhoeven <geert+renesas@glider.be>
Fri, 10 Jan 2020 13:19:24 +0000 (14:19 +0100)
committerGeert Uytterhoeven <geert+renesas@glider.be>
Fri, 21 Feb 2020 12:57:44 +0000 (13:57 +0100)
Add checks for bias register descriptors:
  1. Pull-up and optional pull-down register addresses must be unique,
  2. Referred pins must exist.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Link: https://lore.kernel.org/r/20200110131927.1029-11-geert+renesas@glider.be
drivers/pinctrl/sh-pfc/core.c

index 8304832..fcd11d8 100644 (file)
@@ -888,6 +888,18 @@ static void __init sh_pfc_check_drive_reg(const struct sh_pfc_soc_info *info,
        }
 }
 
+static void __init sh_pfc_check_bias_reg(const struct sh_pfc_soc_info *info,
+                                        const struct pinmux_bias_reg *bias)
+{
+       unsigned int i;
+
+       sh_pfc_check_reg(info->name, bias->puen);
+       if (bias->pud)
+               sh_pfc_check_reg(info->name, bias->pud);
+       for (i = 0; i < ARRAY_SIZE(bias->pins); i++)
+               sh_pfc_check_pin(info, bias->puen, bias->pins[i]);
+}
+
 static void __init sh_pfc_check_info(const struct sh_pfc_soc_info *info)
 {
        const char *drvname = info->name;
@@ -984,6 +996,10 @@ static void __init sh_pfc_check_info(const struct sh_pfc_soc_info *info)
        /* Check drive strength registers */
        for (i = 0; info->drive_regs && info->drive_regs[i].reg; i++)
                sh_pfc_check_drive_reg(info, &info->drive_regs[i]);
+
+       /* Check bias registers */
+       for (i = 0; info->bias_regs && info->bias_regs[i].puen; i++)
+               sh_pfc_check_bias_reg(info, &info->bias_regs[i]);
 }
 
 static void __init sh_pfc_check_driver(const struct platform_driver *pdrv)