staging: rtl8188eu: remove HAL_INIT_PROFILE_TAG
authorMartin Kaiser <martin@kaiser.cx>
Sun, 20 Jun 2021 17:52:56 +0000 (19:52 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 24 Jun 2021 12:42:45 +0000 (14:42 +0200)
Remove HAL_INIT_PROFILE_TAG, which is an empty loop already.

Signed-off-by: Martin Kaiser <martin@kaiser.cx>
Link: https://lore.kernel.org/r/20210620175301.14988-8-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8188eu/hal/usb_halinit.c

index ba80512..05c67e7 100644 (file)
@@ -627,10 +627,6 @@ u32 rtl8188eu_hal_init(struct adapter *Adapter)
        struct pwrctrl_priv             *pwrctrlpriv = &Adapter->pwrctrlpriv;
        struct registry_priv    *pregistrypriv = &Adapter->registrypriv;
 
-       #define HAL_INIT_PROFILE_TAG(stage) do {} while (0)
-
-       HAL_INIT_PROFILE_TAG(HAL_INIT_STAGES_BEGIN);
-
        if (Adapter->pwrctrlpriv.bkeepfwalive) {
                if (haldata->odmpriv.RFCalibrateInfo.bIQKInitialized) {
                        rtl88eu_phy_iq_calibrate(Adapter, true);
@@ -645,7 +641,6 @@ u32 rtl8188eu_hal_init(struct adapter *Adapter)
                goto exit;
        }
 
-       HAL_INIT_PROFILE_TAG(HAL_INIT_STAGES_INIT_PW_ON);
        status = rtw_hal_power_on(Adapter);
        if (status == _FAIL) {
                goto exit;
@@ -668,7 +663,6 @@ u32 rtl8188eu_hal_init(struct adapter *Adapter)
                txpktbuf_bndy = WMM_NORMAL_TX_PAGE_BOUNDARY_88E;
        }
 
-       HAL_INIT_PROFILE_TAG(HAL_INIT_STAGES_MISC01);
        _InitQueueReservedPage(Adapter);
        _InitQueuePriority(Adapter);
        _InitPageBoundary(Adapter);
@@ -676,7 +670,6 @@ u32 rtl8188eu_hal_init(struct adapter *Adapter)
 
        _InitTxBufferBoundary(Adapter, 0);
 
-       HAL_INIT_PROFILE_TAG(HAL_INIT_STAGES_DOWNLOAD_FW);
        if (Adapter->registrypriv.mp_mode == 1) {
                _InitRxSetting(Adapter);
                Adapter->bFWReady = false;
@@ -697,20 +690,17 @@ u32 rtl8188eu_hal_init(struct adapter *Adapter)
 
        rtl88eu_phy_rf_config(Adapter);
 
-       HAL_INIT_PROFILE_TAG(HAL_INIT_STAGES_EFUSE_PATCH);
        status = rtl8188e_iol_efuse_patch(Adapter);
        if (status == _FAIL)
                goto exit;
 
        _InitTxBufferBoundary(Adapter, txpktbuf_bndy);
 
-       HAL_INIT_PROFILE_TAG(HAL_INIT_STAGES_INIT_LLTT);
        status =  InitLLTTable(Adapter, txpktbuf_bndy);
        if (status == _FAIL) {
                goto exit;
        }
 
-       HAL_INIT_PROFILE_TAG(HAL_INIT_STAGES_MISC02);
        /*  Get Rx PHY status in order to report RSSI and others. */
        _InitDriverInfoSize(Adapter, DRVINFO_SZ);
 
@@ -752,13 +742,10 @@ u32 rtl8188eu_hal_init(struct adapter *Adapter)
        haldata->RfRegChnlVal[0] = rtw_hal_read_rfreg(Adapter, (enum rf_radio_path)0, RF_CHNLBW, bRFRegOffsetMask);
        haldata->RfRegChnlVal[1] = rtw_hal_read_rfreg(Adapter, (enum rf_radio_path)1, RF_CHNLBW, bRFRegOffsetMask);
 
-       HAL_INIT_PROFILE_TAG(HAL_INIT_STAGES_TURN_ON_BLOCK);
        _BBTurnOnBlock(Adapter);
 
-       HAL_INIT_PROFILE_TAG(HAL_INIT_STAGES_INIT_SECURITY);
        invalidate_cam_all(Adapter);
 
-       HAL_INIT_PROFILE_TAG(HAL_INIT_STAGES_MISC11);
        /*  2010/12/17 MH We need to set TX power according to EFUSE content at first. */
        phy_set_tx_power_level(Adapter, haldata->CurrentChannel);
 
@@ -783,7 +770,6 @@ u32 rtl8188eu_hal_init(struct adapter *Adapter)
        /* Nav limit , suggest by scott */
        usb_write8(Adapter, 0x652, 0x0);
 
-       HAL_INIT_PROFILE_TAG(HAL_INIT_STAGES_INIT_HAL_DM);
        rtl8188e_InitHalDm(Adapter);
 
        /*  2010/08/11 MH Merge from 8192SE for Minicard init. We need to confirm current radio status */
@@ -807,7 +793,6 @@ u32 rtl8188eu_hal_init(struct adapter *Adapter)
        /* enable tx DMA to drop the redundate data of packet */
        usb_write16(Adapter, REG_TXDMA_OFFSET_CHK, (usb_read16(Adapter, REG_TXDMA_OFFSET_CHK) | DROP_DATA_EN));
 
-       HAL_INIT_PROFILE_TAG(HAL_INIT_STAGES_IQK);
        /*  2010/08/26 MH Merge from 8192CE. */
        if (pwrctrlpriv->rf_pwrstate == rf_on) {
                if (haldata->odmpriv.RFCalibrateInfo.bIQKInitialized) {
@@ -817,15 +802,11 @@ u32 rtl8188eu_hal_init(struct adapter *Adapter)
                        haldata->odmpriv.RFCalibrateInfo.bIQKInitialized = true;
                }
 
-               HAL_INIT_PROFILE_TAG(HAL_INIT_STAGES_PW_TRACK);
-
                ODM_TXPowerTrackingCheck(&haldata->odmpriv);
 
-               HAL_INIT_PROFILE_TAG(HAL_INIT_STAGES_LCK);
                rtl88eu_phy_lc_calibrate(Adapter);
        }
 
-/* HAL_INIT_PROFILE_TAG(HAL_INIT_STAGES_INIT_PABIAS); */
 /*     _InitPABias(Adapter); */
        usb_write8(Adapter, REG_USB_HRPWM, 0);
 
@@ -833,7 +814,6 @@ u32 rtl8188eu_hal_init(struct adapter *Adapter)
        usb_write32(Adapter, REG_FWHW_TXQ_CTRL, usb_read32(Adapter, REG_FWHW_TXQ_CTRL) | BIT(12));
 
 exit:
-       HAL_INIT_PROFILE_TAG(HAL_INIT_STAGES_END);
 
        return status;
 }